Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Create StudioDragAndDrop #13936

Merged
merged 13 commits into from
Nov 7, 2024
Merged

chore: Create StudioDragAndDrop #13936

merged 13 commits into from
Nov 7, 2024

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Oct 29, 2024

Description

  • Moving DragAndDrop to @studio/components

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. kind/dependencies Used for issues or pull requests that are dependency updates frontend labels Oct 29, 2024
@wrt95 wrt95 marked this pull request as draft October 29, 2024 06:37
@wrt95 wrt95 linked an issue Oct 29, 2024 that may be closed by this pull request
@github-actions github-actions bot added the quality/testing Tests that are missing, needs to be created or could be improved. label Oct 29, 2024
@wrt95 wrt95 marked this pull request as ready for review October 29, 2024 13:26
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

Attention: Patch coverage is 92.00000% with 16 lines in your changes missing coverage. Please review.

Project coverage is 95.20%. Comparing base (25069c1) to head (facfdfd).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...oDragAndDropListItem/StudioDragAndDropListItem.tsx 80.43% 8 Missing and 1 partial ⚠️
...op/StudioDragAndDropList/StudioDragAndDropList.tsx 81.81% 2 Missing and 2 partials ⚠️
...dioDragAndDropNewItem/StudioDragAndDropNewItem.tsx 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13936      +/-   ##
==========================================
- Coverage   95.23%   95.20%   -0.03%     
==========================================
  Files        1718     1738      +20     
  Lines       22614    22814     +200     
  Branches     2645     2671      +26     
==========================================
+ Hits        21537    21721     +184     
- Misses        834      847      +13     
- Partials      243      246       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@framitdavid
Copy link
Collaborator

It is possible to increase test cov on this one?

@wrt95
Copy link
Contributor Author

wrt95 commented Nov 6, 2024

It is possible to increase test cov on this one?

As discussed in Slack yesterday, we do not do that in this issue 😄

Copy link
Collaborator

@framitdavid framitdavid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@wrt95 wrt95 added the skip-manual-testing PRs that do not need to be tested manually label Nov 7, 2024
@wrt95 wrt95 merged commit a702c6c into main Nov 7, 2024
8 of 10 checks passed
@wrt95 wrt95 deleted the 13916-StudioDragAndDrop branch November 7, 2024 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend kind/dependencies Used for issues or pull requests that are dependency updates quality/testing Tests that are missing, needs to be created or could be improved. skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create StudioDragAndDrop component from DragAndDrop
2 participants