Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: 13956 inform user when a linked component in subform table is invalid #13987

Merged
merged 8 commits into from
Nov 13, 2024
Merged

feat: 13956 inform user when a linked component in subform table is invalid #13987

merged 8 commits into from
Nov 13, 2024

Conversation

JamalAlabdullah
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah commented Nov 5, 2024 •
edited
Loading

Description

  • Updated EditColumnElement to render just components with labels.
  • Added a description to explain that the list is just components with labels.

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@JamalAlabdullah JamalAlabdullah linked an issue Nov 5, 2024 that may be closed by this pull request
Inform user when a linked component in subform table is invalid #13956
Closed
@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 5, 2024
@JamalAlabdullah JamalAlabdullah changed the title 13956 inform user when a linked component in subform table is invalid feat: 13956 inform user when a linked component in subform table is invalid Nov 5, 2024
@codecov Codecov
Copy link

codecov bot commented Nov 5, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.23%. Comparing base (d339dfc) to head (7be40ec).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #13987   +/-   ##
=======================================
  Coverage   95.23%   95.23%           
=======================================
  Files        1759     1759           
  Lines       23038    23041    +3     
  Branches     2687     2688    +1     
=======================================
+ Hits        21940    21943    +3     
  Misses        848      848           
  Partials      250      250

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

lassopicasso
lassopicasso approved these changes Nov 6, 2024
View reviewed changes
Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Superb solution! 🙂

@JamalAlabdullah
Copy link
Contributor Author

I will also add info message when there is no components with label to show.

@lassopicasso
Copy link
Contributor

A test should be added to ensure that only components with labels are displayed in the selector. That will likely improve the code coverage as well.

I can do another review of the code after that. 🙂

lassopicasso
lassopicasso requested changes Nov 7, 2024
View reviewed changes
Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the separate comment 🙂

lassopicasso
lassopicasso requested changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! 🙂 I have a few comments, including some minor nitpicks and a couple of refactor suggestions.

frontend/language/src/nb.json Outdated Show resolved Hide resolved
...ditor/src/components/Properties/EditSubformTableColumns/ColumnElement/ColumnElement.test.tsx Outdated Show resolved Hide resolved
...roperties/EditSubformTableColumns/ColumnElement/EditColumnElement/EditColumnElement.test.tsx Outdated Show resolved Hide resolved
...roperties/EditSubformTableColumns/ColumnElement/EditColumnElement/EditColumnElement.test.tsx Outdated Show resolved Hide resolved
...nts/Properties/EditSubformTableColumns/ColumnElement/EditColumnElement/EditColumnElement.tsx Outdated Show resolved Hide resolved
lassopicasso
lassopicasso approved these changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome work, @JamalAlabdullah 💯

Jondyr
Jondyr requested changes Nov 11, 2024
View reviewed changes
Copy link
Member

@Jondyr Jondyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we also need to check for datamodel binding on the component here @JamalAlabdullah

Jondyr
Jondyr approved these changes Nov 12, 2024
View reviewed changes
Copy link
Member

@Jondyr Jondyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works ✅

@Jondyr Jondyr force-pushed the 13956-inform-user-when-a-linked-component-in-subform-table-is-invalid branch from 3bf01f8 to 7be40ec Compare November 12, 2024 14:00
@JamalAlabdullah JamalAlabdullah merged commit 5e701b5 into main Nov 13, 2024
10 checks passed
@JamalAlabdullah JamalAlabdullah deleted the 13956-inform-user-when-a-linked-component-in-subform-table-is-invalid branch November 13, 2024 06:57
nkylstad pushed a commit that referenced this pull request Nov 26, 2024
@JamalAlabdullah @nkylstad
feat: 13956 inform user when a linked component in subform table is i…
6198cb7 
…nvalid (#13987)

Co-authored-by: Jamal Alabdullah <jamalalabdullah@Jamals-MacBook-Pro.local>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lassopicasso lassopicasso lassopicasso approved these changes

@Jondyr Jondyr Jondyr approved these changes

Assignees
No one assigned
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Inform user when a linked component in subform table is invalid
3 participants
@JamalAlabdullah @lassopicasso @Jondyr