Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Rename subform component and add help text #13995

Merged
merged 1 commit into from
Nov 11, 2024

Conversation

lassopicasso
Copy link
Contributor

Description

This PR renames the subform component Underskjema to Tabell for underskjema and also adds help text to the component.
Thx for the help, @Ildest and @Annikenkbrathen 💪

Related Issue(s)

  • itself

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@lassopicasso lassopicasso added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. area/text-editor Area: Related to creating, translating and editing texts. added-to-sprint frontend team/studio-domain2 labels Nov 6, 2024
@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Nov 6, 2024
@lassopicasso lassopicasso changed the title Rename subform component style: Rename subform component and add help text Nov 6, 2024
Copy link

codecov bot commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.21%. Comparing base (2ffcc74) to head (2c51861).
Report is 25 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #13995   +/-   ##
=======================================
  Coverage   95.21%   95.21%           
=======================================
  Files        1710     1710           
  Lines       22578    22578           
  Branches     2643     2643           
=======================================
  Hits        21498    21498           
  Misses        834      834           
  Partials      246      246           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamalAlabdullah JamalAlabdullah self-assigned this Nov 7, 2024
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@JamalAlabdullah JamalAlabdullah removed their assignment Nov 7, 2024
Copy link
Member

@Jondyr Jondyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and looks correct✅

@Jondyr Jondyr merged commit 9aba26e into main Nov 11, 2024
14 of 15 checks passed
@Jondyr Jondyr deleted the update-text-subform-component branch November 11, 2024 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added-to-sprint area/text-editor Area: Related to creating, translating and editing texts. area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain2
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants