Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Replace DragAndDrop with StudioDragAndDrop #14002

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Nov 7, 2024

Description

  • Replacing DragAndDrop with StudioDragAndDrop

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 7, 2024
@wrt95 wrt95 linked an issue Nov 7, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.25%. Comparing base (bf7450c) to head (393416d).
Report is 10 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14002      +/-   ##
==========================================
+ Coverage   95.21%   95.25%   +0.03%     
==========================================
  Files        1756     1739      -17     
  Lines       22976    22808     -168     
  Branches     2681     2664      -17     
==========================================
- Hits        21877    21725     -152     
+ Misses        849      836      -13     
+ Partials      250      247       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍

Copy link
Member

@Jondyr Jondyr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works ✅

@wrt95 wrt95 merged commit 3cc37fc into main Nov 14, 2024
10 checks passed
@wrt95 wrt95 deleted the 13917-Replace-DragAndDrop-with-StudioDragAndDrop branch November 14, 2024 06:30
nkylstad pushed a commit that referenced this pull request Nov 26, 2024
Co-authored-by: Jonas Dyrlie <jonas.dyrlie@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-core team/studio-domain1 team/studio-domain2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete all usage of the component and replace with StudioDragAndDrop
3 participants