Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Backend slack integration #14168

Merged
merged 9 commits into from
Nov 26, 2024
Merged

feat: Backend slack integration #14168

merged 9 commits into from
Nov 26, 2024

Conversation

nkylstad
Copy link
Member

@nkylstad nkylstad commented Nov 26, 2024 •
edited
Loading

Description

Backend implementation for feedback form.
This can be viewed as a POC/MVP, in order to start receiving feedback from our users in a simple manner.

  • Created a client for posting messages to slack
    • token and secret portion of webhook url are placed in keyvault (only dev currently)
  • Created controller and endpoint for posting feedback answers to Slack using the new client.

Tested the implementation in dev, and it works as expected. See the #studio-feedback channel in our internal slack for the test responses (ask me for access).

Very happy to get some feedback if there are better ways to solve this!

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. backend labels Nov 26, 2024
@nkylstad nkylstad changed the title Feat/backend slack integration feat: Backend slack integration Nov 26, 2024
mirkoSekulic
mirkoSekulic approved these changes Nov 26, 2024
View reviewed changes
Copy link
Collaborator

@mirkoSekulic mirkoSekulic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work 👏

For tests you can use MockServerFixture to setup the response from slack server.
And you can setup test URL using JsonConfigOverrides.

Similar test could be found here

backend/src/Designer/Controllers/FeedbackFormController.cs Show resolved Hide resolved
@github-actions github-actions bot added the quality/testing Tests that are missing, needs to be created or could be improved. label Nov 26, 2024
@nkylstad nkylstad added the skip-manual-testing PRs that do not need to be tested manually label Nov 26, 2024
@nkylstad nkylstad merged commit a629a0e into main Nov 26, 2024
14 checks passed
@nkylstad nkylstad deleted the feat/backend-slack-integration branch November 26, 2024 12:46
nkylstad added a commit that referenced this pull request Nov 26, 2024
@nkylstad
feat: Backend slack integration (#14168)
ccba19c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] approved these changes

@mirkoSekulic mirkoSekulic mirkoSekulic approved these changes

Assignees
No one assigned
Labels
backend quality/testing Tests that are missing, needs to be created or could be improved. skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkylstad @mirkoSekulic