Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add summary2 property to custom config exclusion list #14207

Conversation

Jondyr
Copy link
Member

@Jondyr Jondyr commented Nov 28, 2024

Description

Removes the info message that this config property is under development, as we have a custom config for this property.

Before:
image
After:
image

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 28, 2024
@Jondyr Jondyr changed the title fix(summary2): add summary2 property to custom config exclusion list fix: add summary2 property to custom config exclusion list Nov 28, 2024
Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice fix

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.46%. Comparing base (72c563a) to head (9e94d15).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14207   +/-   ##
=======================================
  Coverage   95.46%   95.46%           
=======================================
  Files        1803     1803           
  Lines       23488    23488           
  Branches     2719     2719           
=======================================
  Hits        22422    22422           
  Misses        812      812           
  Partials      254      254           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JamalAlabdullah JamalAlabdullah self-assigned this Nov 29, 2024
Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ok in dev 👍

@JamalAlabdullah JamalAlabdullah merged commit 86fb29c into main Nov 29, 2024
17 checks passed
@JamalAlabdullah JamalAlabdullah deleted the 11-28-add_summary2_property_to_custom_config_exclusion_list branch November 29, 2024 10:14
@JamalAlabdullah JamalAlabdullah removed their assignment Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain2
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

3 participants