Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: typesInspector width #14214

Merged
merged 2 commits into from
Nov 29, 2024
Merged

fix: typesInspector width #14214

merged 2 commits into from
Nov 29, 2024

Conversation

ErlingHauan
Copy link
Contributor

@ErlingHauan ErlingHauan commented Nov 29, 2024

Description

  • Increases minimum width, so that the Typer heading and + button can't overlap
  • Increases maximum width, so that long type names can be completely seen without ellipsis

Before

typesInspectorBefore.mp4

After

typesInspectorAfter.mp4

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@github-actions github-actions bot added area/data-modeling Area: Related to data models - e.g. create, edit, use data models. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Nov 29, 2024
Copy link

codecov bot commented Nov 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.45%. Comparing base (0b31e03) to head (416048b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14214      +/-   ##
==========================================
- Coverage   95.46%   95.45%   -0.01%     
==========================================
  Files        1803     1803              
  Lines       23494    23494              
  Branches     2719     2719              
==========================================
- Hits        22428    22427       -1     
- Misses        812      813       +1     
  Partials      254      254              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

so that it can't disappear entirely
@ErlingHauan ErlingHauan added the skip-manual-testing PRs that do not need to be tested manually label Nov 29, 2024
@Konrad-Simso Konrad-Simso added the skip-documentation Issues where updating documentation is not relevant label Nov 29, 2024
Copy link
Contributor

@Konrad-Simso Konrad-Simso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🚀

@Konrad-Simso Konrad-Simso merged commit 2761798 into main Nov 29, 2024
11 checks passed
@Konrad-Simso Konrad-Simso deleted the fix/typesInspector-width branch November 29, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/data-modeling Area: Related to data models - e.g. create, edit, use data models. frontend skip-documentation Issues where updating documentation is not relevant skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain1
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants