Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: 14263 create studio status radio group #14272

Merged
merged 10 commits into from
Jan 7, 2025

Conversation

wrt95
Copy link
Contributor

@wrt95 wrt95 commented Dec 12, 2024

Description

  • Creating a radio group with radio buttons with status colours
Skjermopptak.2024-12-12.kl.12.49.42.mov

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

@wrt95 wrt95 linked an issue Dec 12, 2024 that may be closed by this pull request
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Dec 12, 2024
@wrt95 wrt95 added team/studio-core skip-manual-testing PRs that do not need to be tested manually labels Dec 12, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.57%. Comparing base (d3590da) to head (3883aac).
Report is 30 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14272   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files        1842     1844    +2     
  Lines       23883    23899   +16     
  Branches     2752     2753    +1     
=======================================
+ Hits        22825    22841   +16     
  Misses        801      801           
  Partials      257      257           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@nkylstad nkylstad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job, small and clean PR ❤️
I added a few comments to the tests where you have asked for input. Wrt the question about the selector on accessible name, I think the test is technically correct based on how the component is implemented, and I don't have any better ideas on how to to implement the component itself.
So I suggest we leave it as-is and re-visit later if we feel the need to.

Approved since the only suggested changes I have are for the tests, and these are quite minor 😊

@framitdavid framitdavid merged commit 3c55616 into main Jan 7, 2025
10 checks passed
@framitdavid framitdavid deleted the chore-14263-create-StudioStatusRadioGroup branch January 7, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend skip-manual-testing PRs that do not need to be tested manually solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create StudioStatusRadioGroup component
3 participants