-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: 14263 create studio status radio group #14272
Conversation
...libs/studio-components/src/components/StudioStatusRadioGroup/StudioStatusRadioGroup.test.tsx
Outdated
Show resolved
Hide resolved
...libs/studio-components/src/components/StudioStatusRadioGroup/StudioStatusRadioGroup.test.tsx
Outdated
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14272 +/- ##
=======================================
Coverage 95.57% 95.57%
=======================================
Files 1842 1844 +2
Lines 23883 23899 +16
Branches 2752 2753 +1
=======================================
+ Hits 22825 22841 +16
Misses 801 801
Partials 257 257 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job, small and clean PR ❤️
I added a few comments to the tests where you have asked for input. Wrt the question about the selector on accessible name, I think the test is technically correct based on how the component is implemented, and I don't have any better ideas on how to to implement the component itself.
So I suggest we leave it as-is and re-visit later if we feel the need to.
Approved since the only suggested changes I have are for the tests, and these are quite minor 😊
Description
Skjermopptak.2024-12-12.kl.12.49.42.mov
Related Issue(s)
Verification