-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: if a data model field binding is removed, delete the prop #14297
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14297 +/- ##
=======================================
Coverage 95.52% 95.52%
=======================================
Files 1831 1831
Lines 23785 23790 +5
Branches 2755 2757 +2
=======================================
+ Hits 22720 22725 +5
Misses 807 807
Partials 258 258 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @mlqn ! The code handles a complicated case, and is solid! As we talked about, prob add a test when the value is undefined or null.
I would have approved this, but github won't let me :D
Description
If removed, set the data model field as undefined.
Related Issue(s)
Verification
Documentation