Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove depth validation logic from ux-editor #14303

Merged
merged 2 commits into from
Dec 18, 2024

Conversation

Jondyr
Copy link
Member

@Jondyr Jondyr commented Dec 18, 2024

Description

Removes depth validation when moving or adding components to the layout.

Related Issue(s)

https://digdir.slack.com/archives/C07PN8DMJ2E/p1734510769236189

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@github-actions github-actions bot added area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Dec 18, 2024
@Jondyr Jondyr changed the title Remove depth validation logic from ux-editor fix: remove depth validation logic from ux-editor Dec 18, 2024
@Jondyr Jondyr marked this pull request as ready for review December 18, 2024 08:53
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.56%. Comparing base (fd53718) to head (790ac39).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14303      +/-   ##
==========================================
+ Coverage   95.53%   95.56%   +0.02%     
==========================================
  Files        1834     1834              
  Lines       23852    23843       -9     
  Branches     2756     2754       -2     
==========================================
- Hits        22788    22785       -3     
+ Misses        807      801       -6     
  Partials      257      257              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Jondyr Jondyr added team/studio-domain2 kind/bug Used when there is a defect / something is not working as it should. labels Dec 18, 2024
@Jondyr Jondyr linked an issue Dec 18, 2024 that may be closed by this pull request
@JamalAlabdullah JamalAlabdullah self-assigned this Dec 18, 2024
Copy link
Contributor

@mlqn mlqn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested ok in dev

@JamalAlabdullah JamalAlabdullah merged commit 5f64943 into main Dec 18, 2024
10 checks passed
@JamalAlabdullah JamalAlabdullah deleted the 18-12-remove-group-nested-limitation branch December 18, 2024 15:26
@JamalAlabdullah JamalAlabdullah removed their assignment Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ui-editor Area: Related to the designer tool for assembling app UI in Altinn Studio. frontend kind/bug Used when there is a defect / something is not working as it should. solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain2
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

Remove depth limit for group components
3 participants