Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make slider 100% height and hide thumb in firefox #14305

Merged
merged 3 commits into from
Dec 23, 2024

Conversation

Jondyr
Copy link
Member

@Jondyr Jondyr commented Dec 18, 2024

Description

Add some missing css to make component width setting display correctly on firefox.

Before:
image
After:
image

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

@Jondyr Jondyr changed the title fix: Make slider 100% height and hide thumb in firefox fix: make slider 100% height and hide thumb in firefox Dec 18, 2024
@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Dec 18, 2024
@Jondyr Jondyr linked an issue Dec 18, 2024 that may be closed by this pull request
@Jondyr Jondyr marked this pull request as ready for review December 18, 2024 12:18
Copy link

codecov bot commented Dec 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.56%. Comparing base (cc8754c) to head (53f4475).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14305   +/-   ##
=======================================
  Coverage   95.56%   95.56%           
=======================================
  Files        1843     1843           
  Lines       23886    23886           
  Branches     2752     2752           
=======================================
  Hits        22827    22827           
  Misses        802      802           
  Partials      257      257           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@lassopicasso lassopicasso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done, now should 🔥🦊 be happy!

Copy link
Contributor

@JamalAlabdullah JamalAlabdullah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tesed ok in dev 👍

@JamalAlabdullah JamalAlabdullah merged commit 7738e18 into main Dec 23, 2024
10 checks passed
@JamalAlabdullah JamalAlabdullah deleted the 18-12-fix-firefox-range-slider-css branch December 23, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend solution/studio/designer Issues related to the Altinn Studio Designer solution.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Grid width in Firefox
3 participants