fix: add alert to ReferenceTab.tsx

[Konrad-Simso]

Description

Add alert to ReferenceTab.tsx to inform user of preexisting optionsId.

Related Issue

• Merge "select codelist" and "edit codelist" views #13685

Verification

• Your code builds clean without any errors or warnings
• Manual testing done (required)
• Relevant automated test added (if you find this hard, leave it and we'll help out)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.54%. Comparing base (1b719b9) to head (0c923e2).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main   #14307   +/-   ##
=======================================
  Coverage   95.53%   95.54%           
=======================================
  Files        1860     1860           
  Lines       24094    24104   +10     
  Branches     2779     2783    +4     
=======================================
+ Hits        23019    23029   +10     
  Misses        817      817           
  Partials      258      258           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[standeren]

Is this PR missing some tests that checks for the alert presence? 🙈

And there is still an issue that it looks like one have added a custom codeliste even though the id belongs to a code list in the library.

And nitpicking, but there are lacking som space between the input field and the alert.

[standeren]

Nice!
As mentioned in standup today, there is an issue when typing a custom optionsId and then return to the Kodeliste tab.

And there is and issue when removing the content of the inputfield in the referencetab -> the Kodeliste tab is selected automatically.

[Konrad-Simso]

The issues you mentioned have existed for a while

One of the issues can be fixed by removing this useEffect in OptionTabs.tsx

  useEffect(() => {
    const updatedSelectedOptionsType = getSelectedOptionsType(
      component.optionsId,
      component.options,
      optionListIds,
    );
    setSelectedOptionsType(updatedSelectedOptionsType);
  }, [optionListIds, component.optionsId, component.options, setSelectedOptionsType]);

It would result in the user not being switched between the tabs unless they click on the titles/buttons at the top.

I noticed a new issue with the changes in this PR. If the user types in a optionsId which already exists in the library it will remove everything which has been written.
A possible solution is to create a useState for the text field and make the initial value based on what if the optionsId is from the library or not

The issue you showed with a picture will be fixed be the redesign PR

[standeren]

The issues you mentioned have existed for a while

One of the issues can be fixed by removing this useEffect in OptionTabs.tsx

  useEffect(() => {
    const updatedSelectedOptionsType = getSelectedOptionsType(
      component.optionsId,
      component.options,
      optionListIds,
    );
    setSelectedOptionsType(updatedSelectedOptionsType);
  }, [optionListIds, component.optionsId, component.options, setSelectedOptionsType]);

It would result in the user not being switched between the tabs unless they click on the titles/buttons at the top.

I noticed a new issue with the changes in this PR. If the user types in a optionsId which already exists in the library it will remove everything which has been written. A possible solution is to create a useState for the text field and make the initial value based on what if the optionsId is from the library or not

The issue you showed with a picture will be fixed be the redesign PR

Okey, nice! Lets create a new issue for it since it has existed for a while? 😊

[ErlingHauan]

Testet OK. Ser bra ut 😊

[ErlingHauan]

Jeg la merke til én ting på tampen som muligens kan fikses i denne PR-en. Denne feilmeldingen skulle hatt litt avstand rundt seg:

Oppgi navnet på en kodeliste som ikke finnes i referanse-fanen for å få opp denne.

[Konrad-Simso]

Jeg la merke til én ting på tampen som muligens kan fikses i denne PR-en. Denne feilmeldingen skulle hatt litt avstand rundt seg: Oppgi navnet på en kodeliste som ikke finnes i referanse-fanen for å få opp denne.

Dette vil bli fikset av feat: update codelist config design