-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use codeList in name for code list editor texts hook in library #14328
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #14328 +/- ##
=======================================
Coverage 95.57% 95.57%
=======================================
Files 1841 1841
Lines 23880 23880
Branches 2755 2755
=======================================
Hits 22823 22823
Misses 800 800
Partials 257 257 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice name change 💯
I noticed that the hook is duplicated between the content-library
and options config
in Utforming. Do you think we should continue to have these as duplicates or moved it to shared?
In general, definitely! But in this case, the content library should act as an independent package so we should avoid importing packages from shared 🫣 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Then it looks all good 😄 Thank you for the clarification
Description
codeList
instead ofoptionList
.Related Issue(s)
Verification