Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use codeList in name for code list editor texts hook in library #14328

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

standeren
Copy link
Contributor

Description

  • Change function name for code list editor texts hook in library to use codeList instead of optionList.

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

@github-actions github-actions bot added solution/studio/designer Issues related to the Altinn Studio Designer solution. frontend labels Dec 23, 2024
@standeren standeren added skip-releasenotes Issues that do not make sense to list in our release notes area/content-library Area: Related to library for shared resources team/studio-domain1 skip-manual-testing PRs that do not need to be tested manually skip-documentation Issues where updating documentation is not relevant and removed solution/studio/designer Issues related to the Altinn Studio Designer solution. labels Dec 23, 2024
Copy link

codecov bot commented Dec 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.57%. Comparing base (b14959d) to head (becc47b).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14328   +/-   ##
=======================================
  Coverage   95.57%   95.57%           
=======================================
  Files        1841     1841           
  Lines       23880    23880           
  Branches     2755     2755           
=======================================
  Hits        22823    22823           
  Misses        800      800           
  Partials      257      257           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot added the solution/studio/designer Issues related to the Altinn Studio Designer solution. label Dec 30, 2024
@Konrad-Simso Konrad-Simso self-assigned this Dec 31, 2024
Copy link
Contributor

@Konrad-Simso Konrad-Simso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice name change 💯

I noticed that the hook is duplicated between the content-library and options config in Utforming. Do you think we should continue to have these as duplicates or moved it to shared?

@standeren
Copy link
Contributor Author

Nice name change 💯

I noticed that the hook is duplicated between the content-library and options config in Utforming. Do you think we should continue to have these as duplicates or moved it to shared?

In general, definitely! But in this case, the content library should act as an independent package so we should avoid importing packages from shared 🫣

@standeren standeren assigned Konrad-Simso and unassigned standeren Jan 1, 2025
Copy link
Contributor

@Konrad-Simso Konrad-Simso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Then it looks all good 😄 Thank you for the clarification

@Konrad-Simso Konrad-Simso merged commit 1aa8bb1 into main Jan 2, 2025
9 checks passed
@Konrad-Simso Konrad-Simso deleted the fix-code-list-editor-text-hook-name branch January 2, 2025 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/content-library Area: Related to library for shared resources frontend skip-documentation Issues where updating documentation is not relevant skip-manual-testing PRs that do not need to be tested manually skip-releasenotes Issues that do not make sense to list in our release notes solution/studio/designer Issues related to the Altinn Studio Designer solution. team/studio-domain1
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants