Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update gitea texts to v1.23.1 #14555

Merged
merged 3 commits into from
Feb 3, 2025
Merged

fix: Update gitea texts to v1.23.1 #14555

merged 3 commits into from
Feb 3, 2025

Conversation

mlqn
Copy link
Contributor

@mlqn mlqn commented Jan 31, 2025

Description

Updated gitea texts to v1.23.1

Here are some examples of missing texts that can be tested:

BEFORE AFTER

gitea-text1

gitea-text1_

gitea-text2-

gitea-text2_-

gitea-text3

gitea-text3_

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)

Summary by CodeRabbit

  • Localization
    • Added new keys for time tracking, repository management, and user interface elements in English (US) locale
    • Updated Norwegian (Bokmål) locale translations for improved clarity and accuracy
    • Enhanced localization support with more descriptive phrases and error messages

Copy link
Contributor

coderabbitai bot commented Jan 31, 2025

📝 Walkthrough

Walkthrough

This pull request focuses on updating localization files for Gitea, specifically the English (US) and Norwegian language files. The changes involve adding new keys, updating existing translations, and improving the clarity of user interface text. The modifications enhance the application's localization support, adding new entries for time tracking, repository management, and user interactions while refining existing translations to be more descriptive and user-friendly.

Changes

File Change Summary
gitea/files/locale/base/locale_en-US.ini - Added new keys: test, copy_path, readme, internal_error_skipped, tag_kind, tag_tooltip
- Added time tracking related keys: timetracker_timer_start, timetracker_timer_stop, timetracker_timer_discard, timetracker_timer_manually_add
- Updated report_message and install_desc keys
gitea/files/locale/base/locale_nb-NO.ini - Updated multiple translation entries
- Translated phrases like "More items" to "List flere"
- Updated search, timestamp, and interface-related translations

Possibly related PRs

Suggested labels

text/content, frontend, skip-manual-testing

Suggested reviewers

  • lassopicasso
  • github-actions

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Beta)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@github-actions github-actions bot added the solution/studio/repos Issues related to the Altinn Studio Repos solution (Gitea). label Jan 31, 2025
@mlqn mlqn changed the title fix: Update gitea texts fix: Update gitea texts to v1.23.1 Jan 31, 2025
@mlqn mlqn marked this pull request as ready for review January 31, 2025 12:09
@mlqn mlqn requested a review from mirkoSekulic January 31, 2025 12:11
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 7

🧹 Nitpick comments (1)
gitea/files/locale/base/locale_nb-NO.ini (1)

3791-3791: Empty line at end of file

The file ends with an empty line that should be removed.

-
📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 34ac65e and 40d3524.

📒 Files selected for processing (2)
  • gitea/files/locale/base/locale_en-US.ini (53 hunks)
  • gitea/files/locale/base/locale_nb-NO.ini (34 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Build environment and run e2e test
🔇 Additional comments (10)
gitea/files/locale/base/locale_en-US.ini (10)

96-96: LGTM!

The new test key with value "Test" is a simple and clear translation.


107-107: LGTM!

The new copy_path key with value "Copy path" is consistent with other copy-related translations.


148-148: LGTM!

The new readme key with value "Readme" is appropriately capitalized and consistent with common Git terminology.


164-164: LGTM!

The new internal_error_skipped key with value "Internal error occurred but is skipped: %s" is grammatically correct and includes a placeholder for error details.


183-184: LGTM!

The new tag-related keys are well-defined:

  • tag_kind with value "Search tags..." is consistent with other search placeholders
  • tag_tooltip with value "Search for matching tags. Use '%' to match any sequence of numbers." provides clear instructions

214-217: LGTM!

The new table-related keys are well-organized and clear:

  • buttons.table.add.tooltip - "Add a table"
  • buttons.table.add.insert - "Add"
  • buttons.table.rows - "Rows"
  • buttons.table.cols - "Columns"

230-230: LGTM!

The new report_message key with value "If you believe that this is a Gitea bug, please search for issues on GitHub or open a new issue if necessary." is well-formatted and includes proper HTML for the link.


237-237: LGTM!

The new install_desc key with proper HTML formatting and placeholders for multiple links is well-structured:

Simply <a target="_blank" rel="noopener noreferrer" href="%[1]s">run the binary</a> for your platform, ship it with <a target="_blank" rel="noopener noreferrer" href="%[2]s">Docker</a>, or get it <a target="_blank" rel="noopener noreferrer" href="%[3]s">packaged</a>.

239-239: LGTM!

The new platform_desc key with proper HTML formatting and placeholder is well-structured:

Gitea runs anywhere <a target="_blank" rel="noopener noreferrer" href="%s">Go</a> can compile for: Windows, macOS, Linux, ARM, etc. Choose the one you love!

243-243: LGTM!

The new license_desc key with proper HTML formatting and placeholders is well-structured:

Go get <a target="_blank" rel="noopener noreferrer" href="%[1]s">%[2]s</a>! Join us by <a target="_blank" rel="noopener noreferrer" href="%[3]s">contributing</a> to make this project even better. Don't be shy to be a contributor!

@mlqn mlqn assigned mlqn and unassigned mlqn Feb 3, 2025
@mirkoSekulic mirkoSekulic added the skip-manual-testing PRs that do not need to be tested manually label Feb 3, 2025
@mlqn mlqn merged commit 66dbe10 into main Feb 3, 2025
9 checks passed
@mlqn mlqn deleted the fix/update-gitea-locales branch February 3, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
added-to-sprint skip-manual-testing PRs that do not need to be tested manually solution/studio/repos Issues related to the Altinn Studio Repos solution (Gitea). team/studio-core
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants