Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BugFix: change key for geojson so it updates on change #2729

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

MartinRoberg
Copy link
Contributor

Description

Using altinnrowid from datamodel instead of index+label as key for geojson-components to make sure the geometries update when changed.
Added altinnrowid to geometry and rawgeometry type, and updated utils.ts for map to take altinnrowid into geometry from rawgeometry.

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@bjosttveit bjosttveit self-assigned this Nov 20, 2024
@bjosttveit bjosttveit added external-contribution-❤️ Pull request from a developer outside the Altinn teams. kind/bug Something isn't working labels Nov 20, 2024
Copy link
Member

@bjosttveit bjosttveit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch! 🙌 🙌

@bjosttveit bjosttveit merged commit 37eaaa9 into Altinn:main Nov 20, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contribution-❤️ Pull request from a developer outside the Altinn teams. kind/bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Geometry in map component not updating when changed
2 participants