Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/2370 input autocomplete #2803

Merged
merged 7 commits into from
Dec 12, 2024
Merged

Fix/2370 input autocomplete #2803

merged 7 commits into from
Dec 12, 2024

Conversation

adamhaeger
Copy link
Contributor

Description

Added missing autocomplete support for Input, Dropdown and MultpleSelect.

Will add docs if this PR is accepted.

Related Issue(s)

Verification/QA

  • Manual functionality testing
    • I have tested these changes manually
    • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
    • No testing done/necessary
  • Automated tests
    • Unit test(s) have been added/updated
    • Cypress E2E test(s) have been added/updated
    • No automatic tests are needed here (no functional changes/additions)
    • I want someone to help me make some tests
  • UU/WCAG (follow these guidelines until we have our own)
    • I have tested with a screen reader/keyboard navigation/automated wcag validator
    • No testing done/necessary (no DOM/visual changes)
    • I want someone to help me perform accessibility testing
  • User documentation @ altinn-studio-docs
    • Has been added/updated
    • No functionality has been changed/added, so no documentation is needed
    • I will do that later/have created an issue
  • Support in Altinn Studio
    • Issue(s) created for support in Studio
    • This change/feature does not require any changes to Altinn Studio
  • Sprint board
    • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
    • I don't have permissions to do that, please help me out
  • Labels
    • I have added a kind/* label to this PR for proper release notes grouping
    • I don't have permissions to add labels, please help me out

@adamhaeger adamhaeger added the kind/bug Something isn't working label Dec 10, 2024
Copy link
Contributor

@olemartinorg olemartinorg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! 🙌 Are you sure you wanted to add lots of changes to yarn.lock here as well? I don't see why those are relevant.

@adamhaeger
Copy link
Contributor Author

Looks good! 🙌 Are you sure you wanted to add lots of changes to yarn.lock here as well? I don't see why those are relevant.

Thanks! No I certainly dont want the lockfile changes, lll remove them :)

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
33.3% Coverage on New Code (required ≥ 45%)
16.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@adamhaeger adamhaeger merged commit f7d8680 into main Dec 12, 2024
11 of 14 checks passed
@adamhaeger adamhaeger deleted the fix/2370-input-autocomplete branch December 12, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unsupported component property in documentation
2 participants