Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Dockerfile to include timezone and culture information #226

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

ivarne
Copy link
Member

@ivarne ivarne commented Nov 8, 2024

"PdfGeneratorSettings": {
   "DisplayFooter": true
}

requires globalisation and timezone info in docker images.

This will ensure that new apps gets this setting by default.

# Add globalization timezone support
RUN apk add --no-cache icu-libs tzdata
ENV DOTNET_SYSTEM_GLOBALIZATION_INVARIANT=false

Related Issue(s)

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)
  • All tests run green

Documentation

  • User documentation is updated with a separate linked PR in altinn-studio-docs. (if applicable)

 ```json
"PdfGeneratorSettings": {
    "DisplayFooter": true
}
```

requires globalisation and timezone info in docker images

Altinn/app-lib-dotnet#792
Copy link
Contributor

@martinothamar martinothamar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the docs will just have to say something like "if your app was created before xxx, you will have to add these two lines to your Dockerfile..."

@ivarne ivarne merged commit 506a282 into main Jan 8, 2025
5 checks passed
@ivarne ivarne deleted the add-timezone-culture-docker branch January 8, 2025 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants