fix: Using existing Transmission or Activity IDs should no longer res…

…ult in internal server error on updates (#980) #981
Altinn · Aug 9, 2024 · 0757b33 · 0757b33
1 parent 04e1541
commit 0757b33
Showing 1 changed file with 2 additions and 0 deletions.
diff --git a/...orten.Application/Features/V1/ServiceOwner/Dialogs/Commands/Update/UpdateDialogCommand.cs b/...orten.Application/Features/V1/ServiceOwner/Dialogs/Commands/Update/UpdateDialogCommand.cs
@@ -216,6 +216,7 @@ private async Task AppendActivity(DialogEntity dialog, UpdateDialogDto dto, Canc
             _domainContext.AddError(
                 nameof(UpdateDialogDto.Activities),
                 $"Entity '{nameof(DialogActivity)}' with the following key(s) already exists: ({string.Join(", ", existingIds)}).");
+            return;
         }
 
         dialog.Activities.AddRange(newDialogActivities);
@@ -288,6 +289,7 @@ private async Task AppendTransmission(DialogEntity dialog, UpdateDialogDto dto,
             _domainContext.AddError(
                 nameof(UpdateDialogDto.Transmissions),
                 $"Entity '{nameof(DialogTransmission)}' with the following key(s) already exists: ({string.Join(", ", existingIds)}).");
+            return;
         }
 
         dialog.Transmissions.AddRange(newDialogTransmissions);