Skip to content

Commit

Permalink
fix: shorten secret name for container app job (#422)
Browse files Browse the repository at this point in the history
`Secret names cannot be longer than 20. Please shorten
dialogdbconnectionstringsecreturi`

🤷
  • Loading branch information
arealmaas authored Feb 8, 2024
1 parent deb6cb3 commit 09b2f30
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions .azure/modules/containerAppJob/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ resource job 'Microsoft.App/jobs@2023-05-01' = {
secrets: [
{
// todo: move this and refactor into adding this somewhere else
name: 'dialogdbconnectionstringsecreturi'
name: 'dbconnectionstring'
keyVaultUrl: adoConnectionStringSecretUri
identity: 'System'
}
Expand All @@ -36,7 +36,7 @@ resource job 'Microsoft.App/jobs@2023-05-01' = {
env: [
{
name: 'Infrastructure__DialogDbConnectionString'
secretRef: 'dialogdbconnectionstringsecreturi'
secretRef: 'dbconnectionstring'
}
]
image: image
Expand Down
2 changes: 1 addition & 1 deletion .github/tools/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# Tools

`.github/tools/containerAppJobVerifier.sh` is used to verify the status of a container application job. It checks if the job has completed successfully or not.
`.github/tools/containerAppJobVerifier.sh` is used to verify the status of a container application job. It checks if the job has completed successfully or not

`.github/tools/pwdGenerator.ps1` is used to generate passwords.

Expand Down

0 comments on commit 09b2f30

Please sign in to comment.