Skip to content

Commit

Permalink
fix(azure): rename and fix outputs and pass correct secrets (#416)
Browse files Browse the repository at this point in the history
  • Loading branch information
arealmaas authored Feb 6, 2024
1 parent 94b9885 commit 68f0c8b
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .azure/infrastructure/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -240,5 +240,5 @@ module keyVaultReaderAccessPolicy '../modules/keyvault/addReaderRoles.bicep' = {
}

output resourceGroupName string = resourceGroup.name
output containterAppEnvId string = containerAppEnv.outputs.containerAppEnvId
output containerAppEnvId string = containerAppEnv.outputs.containerAppEnvId
output environmentKeyVaultName string = keyVaultModule.outputs.name
5 changes: 2 additions & 3 deletions .github/workflows/action-deploy-apps.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ jobs:
with:
azcliversion: 2.56.0
inlineScript: |
az containerapp job start -n ${{ steps.deploy.outputs.migrationJobName }} -g ${{ steps.deploy.outputs.resourceGroupName }}
az containerapp job start -n ${{ steps.deploy.outputs.name }} -g ${{ secrets.AZURE_RESOURCE_GROUP_NAME }}
- name: Verify migration
uses: azure/CLI@v1
Expand All @@ -104,7 +104,7 @@ jobs:
with:
azcliversion: ${{ env.AZ_CLI_VERSION }}
inlineScript: |
./.github/tools/containerAppJobVerifier.sh ${{ steps.deploy.outputs.migrationJobName }} ${{ secrets.AZURE_RESOURCE_GROUP_NAME }} ${{ inputs.gitShortSha }}
./.github/tools/containerAppJobVerifier.sh ${{ steps.deploy.outputs.name }} ${{ secrets.AZURE_RESOURCE_GROUP_NAME }} ${{ inputs.gitShortSha }}
- name: Logout from azure
if: ${{failure() || success()}}
Expand All @@ -115,7 +115,6 @@ jobs:
name: Deploy ${{ matrix.name }} to ${{ inputs.environment }}
runs-on: ubuntu-latest
needs: deploy-migration-job
if: ${{ !inputs.skip }}
strategy:
fail-fast: true
matrix:
Expand Down

0 comments on commit 68f0c8b

Please sign in to comment.