Skip to content

Commit

Permalink
chore(applications): improve overview of container app revisions (#1161)
Browse files Browse the repository at this point in the history
<!--- Provide a general summary of your changes in the Title above -->

## Description

Adds a suffix to the revision to it is visible in the overview of
revisions what version this is. The existing revision list is very hard
to read

<img width="719" alt="image"
src="https://github.com/user-attachments/assets/bb0ab8ae-3908-4a5d-ab76-3586d9a9b9d8">


<!--- Describe your changes in detail -->

## Related Issue(s)

- #{issue number}

## Verification

- [ ] **Your** code builds clean without any errors or warnings
- [ ] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **New Features**
- Introduced a `revisionSuffix` parameter for enhanced versioning of
container app deployments, allowing for more granular control over which
version of a container image is deployed.
- Improved flexibility and traceability of container application
deployments through the ability to specify image tags.

- **Bug Fixes**
- Enhanced management of container versions, facilitating easier updates
and rollbacks.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
  • Loading branch information
arealmaas authored Sep 19, 2024
1 parent 85226cc commit a91706f
Show file tree
Hide file tree
Showing 4 changed files with 7 additions and 0 deletions.
1 change: 1 addition & 0 deletions .azure/applications/graphql/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -87,6 +87,7 @@ module containerApp '../../modules/containerApp/main.bicep' = {
apimIp: apimIp
tags: tags
resources: resources
revisionSuffix: imageTag
}
}

Expand Down
1 change: 1 addition & 0 deletions .azure/applications/web-api-eu/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -90,6 +90,7 @@ module containerApp '../../modules/containerApp/main.bicep' = {
apimIp: apimIp
tags: tags
resources: resources
revisionSuffix: imageTag
}
}

Expand Down
1 change: 1 addition & 0 deletions .azure/applications/web-api-so/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ module containerApp '../../modules/containerApp/main.bicep' = {
apimIp: apimIp
tags: tags
resources: resources
revisionSuffix: imageTag
}
}

Expand Down
4 changes: 4 additions & 0 deletions .azure/modules/containerApp/main.bicep
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@ param tags object
@description('CPU and memory resources for the container app')
param resources object?

@description('The suffix for the revision of the container app')
param revisionSuffix string?

var probes = [
{
periodSeconds: 5
Expand Down Expand Up @@ -75,6 +78,7 @@ resource containerApp 'Microsoft.App/containerApps@2024-03-01' = {
}
environmentId: containerAppEnvId
template: {
revisionSuffix: revisionSuffix
scale: {
minReplicas: 1
maxReplicas: 1 // temp disable scaling for outbox scheduling
Expand Down

0 comments on commit a91706f

Please sign in to comment.