Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing content values in transmissions #1197

Closed
elsand opened this issue Sep 25, 2024 · 1 comment
Closed

Missing content values in transmissions #1197

elsand opened this issue Sep 25, 2024 · 1 comment
Assignees
@oskogstad
Labels
bug Something isn't working

Comments

@elsand
Copy link
Member

elsand commented Sep 25, 2024

Description

It appears to be possible to end up with dialogs having transmissions without content valyes

Reproduction

Not repro, but this can be observed in both EU and SO in staging on dialogId ba099101-9899-a574-af8b-85f623e4dd04

Image

Expected behavior

All content objects should contain a value property

Actual behavior

Only the mediaType property is visisble in the DTOs
@elsand elsand added the bug Something isn't working label Sep 25, 2024
@oskogstad oskogstad mentioned this issue Sep 26, 2024
Merged
4 tasks
@oskogstad
Copy link
Collaborator

Pretty sure this is not possible anymore, this might be an old bug/old data ..
I suggest either purging these dialogs or manually adding a localization value if they are needed.

Added test to cover these required values in #1200

@oskogstad oskogstad self-assigned this Sep 26, 2024
oskogstad added a commit that referenced this issue Sep 26, 2024
@oskogstad
chore: Add transmission content values test (#1200)
d5729de 
<!--- Provide a general summary of your changes in the Title above -->

## Description

Adding test for required content on transmissions

## Related Issue(s)

- #1197 

## Verification

- [x] **Your** code builds clean without any errors or warnings
- [x] Manual testing done (required)
- [x] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)


<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit

- **New Features**
- Added support for generating fake dialog transmissions with new
parameters in dialog generation methods.

- **Bug Fixes**
- Introduced validation tests to ensure that dialog transmissions cannot
be created without required content values.

- **Tests**
- Added new test cases to validate the creation of dialog transmissions
under specific conditions.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
@elsand elsand closed this as completed Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oskogstad oskogstad

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@elsand @oskogstad