You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When generating cache keys for system users, the system user id is not part of the list of identifiable claims on which the key is based
Reproduction
Perform a request to a dialog, using a system user that has been granted access to the dialog, owned by the same organization (consumer/supplier)
Perform a request to a dialog, using a different system user that has NOT been granted access to the dialog, owned by the same organization (consumer/supplier)
Expected behavior
OK
Unauthorized
Actual behavior
OK
OK
Additional information
The two requests will have identical cache keys, causing the second request from to hit the cache for the PDP call. This is a security issue, but mitigated by the fact that it must be owned by the same organization.
The text was updated successfully, but these errors were encountered:
## Description
This adds a check to include the system user id in the list of
identifiable claims, which is in turn used to generate a cache key for
authorization requests on dialog details accesses.
## Related Issue(s)
- #1363
## Verification
- [x] **Your** code builds clean without any errors or warnings
- [x] Manual testing done (required)
- [x] Relevant automated test added (if you find this hard, leave it and
we'll help out)
<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->
## Summary by CodeRabbit
- **New Features**
- Introduced methods to simplify the retrieval of system user IDs from
claims.
- Enhanced claims processing to include system user identifiers from
authorization details.
- **Bug Fixes**
- Streamlined logic in handling user ID extraction, improving
efficiency.
- **Tests**
- Added a test to verify the correct extraction of system user
identifiers from claims.
<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Description
When generating cache keys for system users, the system user id is not part of the list of identifiable claims on which the key is based
Reproduction
Expected behavior
Actual behavior
Additional information
The two requests will have identical cache keys, causing the second request from to hit the cache for the PDP call. This is a security issue, but mitigated by the fact that it must be owned by the same organization.
The text was updated successfully, but these errors were encountered: