Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

e2e sentinel purge cleanup reports false error #1547

Closed
oskogstad opened this issue Nov 29, 2024 · 0 comments
Closed

e2e sentinel purge cleanup reports false error #1547

oskogstad opened this issue Nov 29, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@oskogstad
Copy link
Collaborator

Description

e2e purge test fails with

     █ Post run: checking for unpurged dialogs

       ✓ response status: expected 200 to equal 200
       ✓ has valid json body
       ✗ unpurged dialogs: expected 1 to equal +0

IDs that are successfully purged are not removed from the array that the test asserts against.

Reproduction

Run e2e test

Expected behavior

Actual behavior

@oskogstad oskogstad added the bug Something isn't working label Nov 29, 2024
@oskogstad oskogstad self-assigned this Nov 29, 2024
oskogstad added a commit that referenced this issue Nov 29, 2024
Did not remove IDs that were successfully purged

#1547 

<!-- This is an auto-generated comment: release notes by coderabbit.ai
-->

## Summary by CodeRabbit

- **Bug Fixes**
- Improved the logic for purging dialogs to ensure only failed purges
are retained for further inspection.
- Streamlined logging by removing unnecessary output upon purge failure.

<!-- end of auto-generated comment: release notes by coderabbit.ai -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

No branches or pull requests

2 participants