-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change usage of double colon to single colon for scalar structured identifiers #700
Comments
I've grown ambivalent to the whole double colon thing. While it provides a fairly robust way of splitting namespace from value in a scalar string, it's a bit unorthodox and not really used anywhere else (not even in Altinn). We should consider keeping this being a single colon, and always consider the last element when splitting by ":" to be the value, and expect any literal colons within the value to be URL encoded (ie |
I've discussed this briefly with @altinnadmin, and we want to change this back to using just a single colon. Ie. splitting logic will have to change from splitting on "::" to splitting on a single colon and treat the last item as the value. I'll go ahead and change this issue to reflect this. |
<!--- Provide a general summary of your changes in the Title above --> ## Description Change party identifier separator to single colon <!--- Describe your changes in detail --> ## Related Issue(s) - #700 ## Verification - [x] **Your** code builds clean without any errors or warnings - [x] Manual testing done (required) - [ ] Relevant automated test added (if you find this hard, leave it and we'll help out) ## Documentation - [ ] Documentation is updated (either in `docs`-directory, Altinnpedia or a separate linked PR in [altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if applicable) Co-authored-by: Ole Jørgen Skogstad <skogstad@softis.net>
Introduction
There's currently a disparity between "party" and "serviceResource" encoding.
The rest of Altinn is using a single colon, and treating the last item as the value within the NSS-part of the URN in scenarios where we need to split this into eg. XACML attribute ids and values. Using a single colon is also more in line with typical NSS-usage (see examples on the wikipedia-page).
If we for some reason need to have a literal colon as the value, it should be percent-escaped, but no known case for this currently exists so code for this (handling escaping) should not be added at this time.
Tasks
The text was updated successfully, but these errors were encountered: