Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move front channel embeds to content (localized) #856

Closed
6 tasks done
Tracked by #836
elsand opened this issue Jun 17, 2024 · 0 comments
Closed
6 tasks done
Tracked by #836

Move front channel embeds to content (localized) #856

elsand opened this issue Jun 17, 2024 · 0 comments
Assignees

Comments

@elsand
Copy link
Member

elsand commented Jun 17, 2024

Introduction

Front channel embeds should be a part of content in order to be localized

Description

As a part of the redesign of the model, front channel embeds are removed from dialog elements and placed within the content-structure

Implementation

Here is a suggestion to how this can be implemented. We add a "mediaType" property to content, which - if recognized and valid - lets arbeidsflate know that this is to be rendered as a front channel embed.

We define some value for "type" which is used for this. This should typically be rendered immediately after "AdditionalInfo"

{ 
    "type": "MainContentReference",
    "mediaType": "application/vnd.dialogporten.frontchannelembed+json;type=markdown", 
    "value": [ { "cultureCode": "nb_NO", "value": "https://someendpoint-supporting-cors-and-dialogtokens.com/somemarkdown_nb.md" } ]
}

Tasks

Preview Give feedback

Threat modelling

Preview Give feedback

Acceptance criteria

GIVEN ...
WHEN ....
THEN ...

GIVEN ...
WHEN ....
THEN ...

@elsand elsand added needs consideration Requires additional consideration and removed needs consideration Requires additional consideration labels Jun 17, 2024
oskogstad added a commit that referenced this issue Jun 19, 2024
<!--- Provide a general summary of your changes in the Title above -->

## Description

<!--- Describe your changes in detail -->

This moves the front channel embeds to the content, and adds a new type
`MainContentReference`.
`MainContentReference` must be an URL.

Added support for markdown in `AdditionalInfo`

## Related Issue(s)

- #856 

## Verification

- [x] **Your** code builds clean without any errors or warnings
- [x] Manual testing done (required)
- [ ] Relevant automated test added (if you find this hard, leave it and
we'll help out)

## Documentation

- [ ] Documentation is updated (either in `docs`-directory, Altinnpedia
or a separate linked PR in
[altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if
applicable)

---------
Co-authored-by: Knut Haug <knut.espen.haug@digdir.no>
Co-authored-by: Bjørn Dybvik Langfors <bdl@digdir.no>
@elsand elsand closed this as completed Jun 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants