-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change activity model and types #858
Comments
Closed
github-project-automation
bot
moved this to New issues
in ⚠️ Dialogporten / Arbeidsflate - GAMMEL - se https://github.com/orgs/Altinn/projects/146 ⚠️
Jun 17, 2024
elsand
added
needs consideration
Requires additional consideration
and removed
needs consideration
Requires additional consideration
labels
Jun 17, 2024
elsand
moved this from New issues
to Ready
in ⚠️ Dialogporten / Arbeidsflate - GAMMEL - se https://github.com/orgs/Altinn/projects/146 ⚠️
Jun 24, 2024
arealmaas
moved this from Ready
to Doing
in ⚠️ Dialogporten / Arbeidsflate - GAMMEL - se https://github.com/orgs/Altinn/projects/146 ⚠️
Jul 23, 2024
4 tasks
arealmaas
moved this from Doing
to Code Review og PR
in ⚠️ Dialogporten / Arbeidsflate - GAMMEL - se https://github.com/orgs/Altinn/projects/146 ⚠️
Jul 24, 2024
arealmaas
added a commit
that referenced
this issue
Jul 25, 2024
<!--- Provide a general summary of your changes in the Title above --> ## Description - Adds validation that ensures Description only can be set if Type is Information - Rename values for DialogActivity according to issue - Fix tests and add migration for the refactor <!--- Describe your changes in detail --> ## Related Issue(s) - #858 ## Verification - [ ] **Your** code builds clean without any errors or warnings - [ ] Manual testing done (required) - [ ] Relevant automated test added (if you find this hard, leave it and we'll help out) ## Documentation - [ ] Documentation is updated (either in `docs`-directory, Altinnpedia or a separate linked PR in [altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if applicable) --------- Co-authored-by: Ole Jørgen Skogstad <skogstad@softis.net>
oskogstad
moved this from Code Review og PR
to Testing / Design QA
in ⚠️ Dialogporten / Arbeidsflate - GAMMEL - se https://github.com/orgs/Altinn/projects/146 ⚠️
Jul 31, 2024
oskogstad
moved this from Testing / Design QA
to Doing
in ⚠️ Dialogporten / Arbeidsflate - GAMMEL - se https://github.com/orgs/Altinn/projects/146 ⚠️
Jul 31, 2024
oskogstad
added a commit
that referenced
this issue
Jul 31, 2024
oskogstad
moved this from Doing
to Testing / Design QA
in ⚠️ Dialogporten / Arbeidsflate - GAMMEL - se https://github.com/orgs/Altinn/projects/146 ⚠️
Aug 1, 2024
arealmaas
moved this from Testing / Design QA
to Done
in ⚠️ Dialogporten / Arbeidsflate - GAMMEL - se https://github.com/orgs/Altinn/projects/146 ⚠️
Aug 2, 2024
arealmaas
closed this as completed
by moving to Done
in
⚠️ Dialogporten / Arbeidsflate - GAMMEL - se https://github.com/orgs/Altinn/projects/146 ⚠️
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Introduction
The activity model should be changed to reflect the new dialog aggregate version
Description
Some renames and validation changes should be performed on the dialog activity model. This includes using the model in #851 as
performedBy
, changing the valid types and chaning the validationsImplementation
The model should look something like this
Valid types should be:
The "description" (localizationtext) property should still be available, but only allowed (and required) if type is "information". The other types should not allow for a textual override, as the type itself should provide a non-ambiguous semantic.
See #851 for performedBy model.
Tasks
Threat modelling
Acceptance criteria
GIVEN ...
WHEN ....
THEN ...
GIVEN ...
WHEN ....
THEN ...
The text was updated successfully, but these errors were encountered: