Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Update az CLI to 2.67.0 #1559

Merged
merged 1 commit into from
Dec 4, 2024
Merged

Conversation

oskogstad
Copy link
Collaborator

@oskogstad oskogstad commented Dec 4, 2024

  • Updates
    • Updated Azure CLI version from 2.64.0 to 2.67.0 in deployment workflows.

@oskogstad oskogstad requested review from a team as code owners December 4, 2024 14:01
Copy link
Contributor

coderabbitai bot commented Dec 4, 2024

📝 Walkthrough

Walkthrough

The pull request updates two GitHub Actions workflow files to enhance deployment processes by modifying the Azure CLI version and restructuring deployment steps based on the dryRun input. The AZ_CLI_VERSION environment variable is updated from 2.64.0 to 2.67.0. Deployment jobs are split into distinct steps for dry runs and actual deployments, with conditional execution based on the dryRun input. This change improves the clarity and control of the deployment workflow.

Changes

File Path Change Summary
.github/workflows/workflow-deploy-apps.yml - Updated AZ_CLI_VERSION from 2.64.0 to 2.67.0.
- Split deployment steps based on dryRun input.
.github/workflows/workflow-deploy-infra.yml - Updated AZ_CLI_VERSION from 2.64.0 to 2.67.0.
- Added conditional execution for deploy-dry-run and deploy steps based on inputs.dryRun.
- Retained echo "::set-output" commands for managing outputs.

Possibly related PRs

Suggested reviewers

  • elsand
  • MagnusSandgren

📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between f7e46c1 and 8abbe02.

📒 Files selected for processing (2)
  • .github/workflows/workflow-deploy-apps.yml (4 hunks)
  • .github/workflows/workflow-deploy-infra.yml (2 hunks)
🔇 Additional comments (5)
.github/workflows/workflow-deploy-infra.yml (2)

4-4: LGTM: Azure CLI version update

The update of AZ_CLI_VERSION to 2.67.0 aligns with the PR objective.


114-114: LGTM: Well-structured deployment steps

The deployment logic is now clearly separated into dry run and actual deployment steps, with proper conditional execution based on the dryRun input. The --what-if flag in dry run ensures safe preview of changes.

Also applies to: 97-97

.github/workflows/workflow-deploy-apps.yml (3)

3-3: LGTM: Consistent Azure CLI version update

The update of AZ_CLI_VERSION to 2.67.0 is consistent with the infrastructure workflow.


97-97: LGTM: Consistent deployment structure across all components

The deployment logic for migration job, apps, and jobs follows the same well-structured pattern:

  • Dry run with --what-if flag when dryRun is true
  • Actual deployment when dryRun is false
  • Verification steps properly skip during dry runs

Also applies to: 195-195, 283-283


3-3: Verify Azure CLI version compatibility

Let's verify that version 2.67.0 doesn't introduce breaking changes that could affect our workflows.

Also applies to: 4-4


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

sonarqubecloud bot commented Dec 4, 2024

@oskogstad oskogstad merged commit 78a832b into main Dec 4, 2024
27 checks passed
@oskogstad oskogstad deleted the chore/ci-update-az-cli branch December 4, 2024 14:32
@coderabbitai coderabbitai bot mentioned this pull request Dec 11, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant