fix(graphql): Add missing activity types #1684
Conversation
📝 WalkthroughWalkthroughThe pull request introduces modifications to the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/Digdir.Domain.Dialogporten.GraphQl.Unit.Tests/ObjectTypes/ActivityTests.cs (1)
8-22: Consider strengthening the enum comparison test.While the test verifies basic enum consistency, it could be more robust:
- The current implementation relies on enum order matching
- It doesn't verify enum values or descriptions
Consider this more thorough implementation:
[Fact] public void Activity_Types_In_GraphQl_Must_Match_Domain_Types() { // Arrange var domainTypes = Enum.GetValues(typeof(DialogActivityType.Values)).Cast<DialogActivityType.Values>().ToList(); var graphQlTypes = Enum.GetValues(typeof(ActivityType)).Cast<ActivityType>().ToList(); // Assert Assert.Equal(domainTypes.Count, graphQlTypes.Count); - for (var i = 0; i < domainTypes.Count; i++) - { - Assert.Equal(domainTypes[i].ToString(), graphQlTypes[i].ToString()); - } + foreach (var domainType in domainTypes) + { + var graphQlType = graphQlTypes.FirstOrDefault(x => + x.ToString().Equals(domainType.ToString(), StringComparison.OrdinalIgnoreCase) && + (int)x == (int)domainType); + Assert.NotNull(graphQlType); + } }
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (3)
docs/schema/V1/schema.verified.graphql(1 hunks)src/Digdir.Domain.Dialogporten.GraphQL/EndUser/Common/ObjectTypes.cs(2 hunks)tests/Digdir.Domain.Dialogporten.GraphQl.Unit.Tests/ObjectTypes/ActivityTests.cs(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Dry run deploy apps / Deploy service to test
- GitHub Check: build / build-and-test
🔇 Additional comments (2)
src/Digdir.Domain.Dialogporten.GraphQL/EndUser/Common/ObjectTypes.cs (1)
76-92: LGTM! New activity types follow consistent naming and description patterns.The new enum values are well-documented and follow the established pattern:
- Consistent "Indicates that" prefix in descriptions
- Clear and descriptive names
- Sequential enum values
docs/schema/V1/schema.verified.graphql (1)
321-332: Verify GraphQL enum value naming convention.The new enum values follow GraphQL naming conventions with SCREAMING_SNAKE_CASE. However, let's verify the usage patterns across the codebase.
✅ Verification successful
GraphQL enum values follow correct naming convention
All enum values in the schema, including the new ones (
DIALOG_DELETED,DIALOG_RESTORED, etc.), correctly follow the GraphQL convention of using SCREAMING_SNAKE_CASE.🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for any GraphQL enum values not following SCREAMING_SNAKE_CASE rg -g '*.graphql' '[a-z][A-Z]' docs/schemaLength of output: 11535
Description
Related Issue(s)
Verification
Documentation
docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)