chore: Misc. typos #1740
Merged
chore: Misc. typos #1740
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📝 WalkthroughWalkthroughThe pull request introduces various textual corrections across multiple files in the Dialogporten project. Key changes include correcting the spelling of "occured" to "occurred," adjusting hyphenation in phrases such as "up-to-date" to "up to date," and refining error messages for consistency. Additionally, property names have been updated to improve clarity, such as changing Changes
Possibly related PRs
Suggested reviewers
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (5)
🚧 Files skipped from review as they are similar to previous changes (5)
⏰ Context from checks skipped due to timeout of 90000ms (3)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Closed
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 4
🧹 Nitpick comments (1)
src/Digdir.Domain.Dialogporten.Domain/Common/EventPublisher/IDomainEvent.cs (1)
18-20: LGTM! Consider tracking the deprecation.Good approach making the property nullable and adding clear documentation about the planned removal.
Would you like me to help create an issue to track the removal of this property once all message bus references are cleared?
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (6)
src/Digdir.Domain.Dialogporten.Application/Features/V1/Common/Events/AltinnForwarders/DialogActivityEventToAltinnForwarder.cs(1 hunks)src/Digdir.Domain.Dialogporten.Application/Features/V1/Common/Events/AltinnForwarders/DialogEventToAltinnForwarder.cs(4 hunks)src/Digdir.Domain.Dialogporten.Domain/Common/DomainEvents/DomainEvent.cs(1 hunks)src/Digdir.Domain.Dialogporten.Domain/Common/EventPublisher/IDomainEvent.cs(1 hunks)src/Digdir.Domain.Dialogporten.Domain/Outboxes/OutboxMessage.cs(1 hunks)src/Digdir.Domain.Dialogporten.Infrastructure/Persistence/Interceptors/ConvertDomainEventsToOutboxMessagesInterceptor.cs(2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
- src/Digdir.Domain.Dialogporten.Infrastructure/Persistence/Interceptors/ConvertDomainEventsToOutboxMessagesInterceptor.cs
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: build / build-and-test
🔇 Additional comments (1)
src/Digdir.Domain.Dialogporten.Domain/Common/EventPublisher/IDomainEvent.cs (1)
22-25: LGTM! Verify consumer updates.The new property is well-documented and correctly typed.
Let's verify that consumers are updated to use the new property:
✅ Verification successful
Migration strategy for OccurredAt property is properly implemented
The codebase shows a well-thought-out transition:
- Old property is maintained for message bus compatibility
- Consumers handle both properties with proper fallback
- New code correctly sets the new property
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Search for any remaining direct usage of OccuredAt rg -l "OccuredAt" --type cs # Search for places where OccurredAt is used to ensure proper migration rg -l "OccurredAt" --type csLength of output: 1027
Script:
#!/bin/bash # Check actual usage context of both spellings echo "=== Checking OccuredAt usage ===" rg "OccuredAt" --type cs -C 2 echo -e "\n=== Checking OccurredAt usage ===" rg "OccurredAt" --type cs -C 2Length of output: 12662
src/Digdir.Domain.Dialogporten.Domain/Common/DomainEvents/DomainEvent.cs
Outdated
Show resolved
Hide resolved
src/Digdir.Domain.Dialogporten.Domain/Outboxes/OutboxMessage.cs
Outdated
Show resolved
Hide resolved
...plication/Features/V1/Common/Events/AltinnForwarders/DialogActivityEventToAltinnForwarder.cs
Outdated
Show resolved
Hide resolved
...orten.Application/Features/V1/Common/Events/AltinnForwarders/DialogEventToAltinnForwarder.cs
Outdated
Show resolved
Hide resolved
knuhau
previously approved these changes
Jan 27, 2025
arealmaas
previously approved these changes
Jan 27, 2025
MagnusSandgren
previously approved these changes
Jan 28, 2025
4 tasks
arealmaas
pushed a commit
that referenced
this pull request
Jan 29, 2025
🤖 I have created a release *beep* *boop* --- ## [1.47.4](v1.47.3...v1.47.4) (2025-01-29) ### Miscellaneous Chores * **deps:** update dependency coverlet.collector to 6.0.4 ([#1750](#1750)) ([7d8bb26](7d8bb26)) * **deps:** update dependency vitest to v3.0.3 ([#1748](#1748)) ([6ee8d28](6ee8d28)) * **deps:** update otel/opentelemetry-collector-contrib docker tag to v0.118.0 ([#1751](#1751)) ([2e3ae4d](2e3ae4d)) * Misc. typos ([#1740](#1740)) ([d83c7a0](d83c7a0)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes a domain event property name
There might be events in the db/on the bus with the old property name at the time of deployment, so for a time we need to check for both.
When we are certain there are no events with the old name left, we can remove the old property (and the nullability)