Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: refactor build test and publish #328

Merged
merged 16 commits into from
Jan 10, 2024
Merged

ci: refactor build test and publish #328

merged 16 commits into from
Jan 10, 2024

Conversation

arealmaas
Copy link
Collaborator

@arealmaas arealmaas commented Jan 9, 2024 •
edited
Loading

  • Refactor build test and publish to buildTest and publish
  • Refactored "Download bicep artifacts" to checkout to avoid publishing logic in build step
  • Refactor publish and deploy action to pass secrets and inputs explicitly

Related to #325

@arealmaas arealmaas changed the base branch from ci/refactor-pull-request-wf to main January 9, 2024 14:30
@arealmaas arealmaas mentioned this pull request Jan 10, 2024
Closed
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@arealmaas arealmaas merged commit 6f98540 into main Jan 10, 2024
1 check passed
@arealmaas arealmaas deleted the ci/refactor-build-test-and-publish branch January 10, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskogstad oskogstad oskogstad approved these changes

@MagnusSandgren MagnusSandgren Awaiting requested review from MagnusSandgren

@knuhau knuhau Awaiting requested review from knuhau

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arealmaas @oskogstad