Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(azure): ensure key vault url is correct and add keyvault readerrole for migration job #597

Merged
merged 1 commit into from
Apr 9, 2024
Merged

fix(azure): ensure key vault url is correct and add keyvault readerrole for migration job #597

merged 1 commit into from
Apr 9, 2024

Conversation

arealmaas
Copy link
Collaborator

  • Maybe the container app job needs read permissions to the key vault so testing adding that
  • Use hardcoded URL to the secret to make sure we use the correct reference

@arealmaas arealmaas requested a review from a team as a code owner April 5, 2024 11:44
@arealmaas arealmaas changed the title fix(azure): ensure key vault url is correct and add keyvault readerrole fix(azure): ensure key vault url is correct and add keyvault readerrole for migration job Apr 5, 2024
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Apr 5, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@arealmaas arealmaas merged commit 2f11a16 into main Apr 9, 2024
15 checks passed
@arealmaas arealmaas deleted the fix/azure-use-hardcoded-secret branch April 9, 2024 10:47
@dialogporten-bot dialogporten-bot mentioned this pull request Apr 9, 2024
Merged
oskogstad added a commit that referenced this pull request Apr 9, 2024
@dialogporten-bot @oskogstad
chore(main): release 1.4.0 (#588)
c1b3187 
🤖 I have created a release *beep* *boop*
---


##
[1.4.0](v1.3.0...v1.4.0)
(2024-04-09)


### Features

* Split SeenLog from activities
([#598](#598))
([71b77d2](71b77d2))
* *This is a breaking change*, the `Seen` activity type has been
removed, and all activities of this type is removed from the staging
environment.
* Add EU endpoints for seen log
([#607](#607))
([1aa7eeb](1aa7eeb))
  * `/api/v1/enduser/dialogs/{dialogId}/seenlog`
  * `/api/v1/enduser/dialogs/{dialogId}/seenlog/{seenLogId}`
  * `/api/v1/serviceowner/dialogs/{dialogId}/seenlog`
  * `/api/v1/serviceowner/dialogs/{dialogId}/seenlog/{seenLogId}`
* Add ExtendedStatus content type
([#589](#589))
([a9f10b0](a9f10b0))
* add fusion cache
([#579](#579))
([973fa5c](973fa5c))
* **azure:** copy from keyvault to app config
([#593](#593))
([d216c90](d216c90))
* **service:** use in-memory transport instead of rabbitmq
([#602](#602))
([dc339e7](dc339e7))


### Bug Fixes

* Add PartyIdentifier.Separator to party validation error
([#595](#595))
([14ee4a1](14ee4a1))
* **azure:** ensure key vault url is correct and add keyvault readerrole
for migration job
([#597](#597))
([2f11a16](2f11a16))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: Ole Jørgen Skogstad <skogstad@softis.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elsand elsand elsand approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arealmaas @elsand