fix: ensure performed by is set for activities #628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arealmaas
commented
Apr 12, 2024
src/Digdir.Domain.Dialogporten.Application/Externals/IOrganizationRegistry.cs
Show resolved
Hide resolved
arealmaas
commented
Apr 15, 2024
...Domain.Dialogporten.Infrastructure/Altinn/OrganizationRegistry/OrganizationRegistryClient.cs
Outdated
Show resolved
Hide resolved
arealmaas
commented
Apr 15, 2024
...ogporten.Application/Features/V1/ServiceOwner/Dialogs/Commands/Update/UpdateDialogCommand.cs
Outdated
Show resolved
Hide resolved
oskogstad
reviewed
Apr 16, 2024
tests/Digdir.Domain.Dialogporten.Application.Integration.Tests/Common/DialogApplication.cs
Outdated
Show resolved
Hide resolved
elsand
reviewed
Apr 16, 2024
| @@ -7,6 +7,7 @@ namespace Digdir.Domain.Dialogporten.Application.Common; | |||
| public interface IUserOrganizationRegistry | |||
There was a problem hiding this comment.
Ikke innført i denne PR-en, men jeg synes at bruken av "organization" blir misvisende, siden det er snakk om tjenesteeiere (som vi ellers kaller "service owners") og ikke bare hvilken som helst organisasjon. Har eksperimentert litt i en branch, som jeg mener har en bedre oppdeling mht externals-servicene og "current user"-servicene, som altså er sammenstillingene av IUser og externals-ene (implementasjonen har dog andre problemer som er knyttet til usertype, så den er ikke brukanes pt)
…/Common/DialogApplication.cs Co-authored-by: Ole Jørgen Skogstad <skogstad@softis.net>
...ain.Dialogporten.Application/Features/V1/Common/DialogActivities/DialogActivityExtensions.cs
Outdated
Show resolved
Hide resolved
...ain.Dialogporten.Application/Features/V1/Common/DialogActivities/DialogActivityExtensions.cs
Outdated
Show resolved
Hide resolved
...ogporten.Application/Features/V1/ServiceOwner/Dialogs/Commands/Create/CreateDialogCommand.cs
Outdated
Show resolved
Hide resolved
...ogporten.Application/Features/V1/ServiceOwner/Dialogs/Commands/Update/UpdateDialogCommand.cs
Outdated
Show resolved
Hide resolved
...ogporten.Application/Features/V1/ServiceOwner/Dialogs/Commands/Update/UpdateDialogCommand.cs
Outdated
Show resolved
Hide resolved
…V1/ServiceOwner/Dialogs/Commands/Create/CreateDialogCommand.cs Co-authored-by: Magnus Sandgren <5285192+MagnusSandgren@users.noreply.github.com>
…V1/ServiceOwner/Dialogs/Commands/Update/UpdateDialogCommand.cs Co-authored-by: Magnus Sandgren <5285192+MagnusSandgren@users.noreply.github.com>
oskogstad
reviewed
Apr 17, 2024
...ain.Dialogporten.Application/Features/V1/Common/DialogActivities/DialogActivityExtensions.cs
Outdated
Show resolved
Hide resolved
oskogstad
reviewed
Apr 17, 2024
...ogporten.Application/Features/V1/ServiceOwner/Dialogs/Commands/Create/CreateDialogCommand.cs
Show resolved
Hide resolved
|
oskogstad
approved these changes
Apr 19, 2024
oskogstad
pushed a commit
that referenced
this pull request
May 7, 2024
🤖 I have created a release *beep* *boop* --- ## [1.6.0](v1.5.0...v1.6.0) (2024-05-07) ### Features * Add authorization caching ([#591](#591)) ([2f86d7e](2f86d7e)) * Add GraphQL POC ([#636](#636)) ([c779eac](c779eac)) * Add support for apps as serviceresource ([#658](#658)) ([adf91ce](adf91ce)) * Authorized parties endpoint in enduser API ([#661](#661)) ([050ccbb](050ccbb)) ### Bug Fixes * Accept app references with urn:altinn:resource prefix ([#685](#685)) ([c9a5606](c9a5606)) * ensure performed by is set for activities ([#628](#628)) ([1adf075](1adf075)) * Use HttpClient wrappers that ensure success to match FusionCache expectations ([#684](#684)) ([7c1e966](7c1e966)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
4 tasks
arealmaas
added a commit
that referenced
this pull request
Jun 5, 2024
<!--- Provide a general summary of your changes in the Title above --> ## Description <!--- Describe your changes in detail --> ## Related Issue(s) - #760 - Reverting #628 - Changing PerformedBy to be a string value ## Verification - [X] **Your** code builds clean without any errors or warnings - [X] Manual testing done (required) - [x] Relevant automated test added (if you find this hard, leave it and we'll help out) ## Documentation - [ ] Documentation is updated (either in `docs`-directory, Altinnpedia or a separate linked PR in [altinn-studio-docs.](https://github.com/Altinn/altinn-studio-docs), if applicable) --------- Co-authored-by: Ole Jørgen Skogstad <skogstad@softis.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before refactoring more, let's do a review on this if this is the best approach or not..
Description
Related Issue(s)
Verification
Documentation
docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)