Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(azure): fix redis deployment #847

Merged
merged 5 commits into from
Jun 12, 2024
Merged

fix(azure): fix redis deployment #847

merged 5 commits into from
Jun 12, 2024

Conversation

arealmaas
Copy link
Collaborator

@arealmaas arealmaas commented Jun 12, 2024 •
edited
Loading

Description

  • Add correct values for Redis private endpoint and dns group zone
  • A clickops change to the default subnet seems to have changed the sequence in which they are outputed in ARM 🙃 So using resourceId() instead of array index.. That was a maajor gotcha..

Related Issue(s)

  • #{issue number}

Verification

  • Your code builds clean without any errors or warnings
  • Manual testing done (required)
  • Relevant automated test added (if you find this hard, leave it and we'll help out)

Documentation

  • Documentation is updated (either in docs-directory, Altinnpedia or a separate linked PR in altinn-studio-docs., if applicable)

@arealmaas arealmaas requested a review from a team as a code owner June 12, 2024 15:28
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@arealmaas arealmaas merged commit 23781e6 into main Jun 12, 2024
14 checks passed
@arealmaas arealmaas deleted the chore/maybe-fix-redis-private-link-build branch June 12, 2024 15:37
@dialogporten-bot dialogporten-bot mentioned this pull request Jun 12, 2024
Merged
arealmaas pushed a commit that referenced this pull request Jun 12, 2024
@dialogporten-bot
chore(main): release 1.8.1 (#848)
2d25a94 
🤖 I have created a release *beep* *boop*
---


##
[1.8.1](v1.8.0...v1.8.1)
(2024-06-12)


### Bug Fixes

* **azure:** fix redis deployment
([#847](#847))
([23781e6](23781e6))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@oskogstad oskogstad oskogstad approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arealmaas @oskogstad