bpf: force inline functions #712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clang version 18.1.3 on Ubuntu 24.04.1 LTS ignores the hint 'inline' while compiling bpf/tcp-services.c, which, in turn, leads to Gatekeeper servers to fail to load that BPF. clang does this because some inline functions in bpf/tcp-services.c increase the number of jumping states a lot (see is_port_listed_forward() and is_port_listed_back()). Although clang's decision is smart from an optimization point of view, it breaks Gatekeeper because DPDK's BPF library does not support a BPF function to call another BPF function.
AltraMayor
added
the
Production requirement
|
@ShawnLeung87 confirmed the solution. See issue #711. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
clangversion 18.1.3 on Ubuntu 24.04.1 LTS ignores the hintinlinewhile compilingbpf/tcp-services.c, which, in turn, leads to Gatekeeper servers to fail to load that BPF.clangdoes this because some inline functions inbpf/tcp-services.cincrease the number of jumping states a lot (seeis_port_listed_forward()andis_port_listed_back()).Although
clang's decision is smart from an optimization point of view, it breaks Gatekeeper because DPDK's BPF library does not support a BPF function to call another BPF function.