Merge pull request #61 from AliMD/feat/review

Review and update all scripts

.editorconfig

@@ -1,4 +1,4 @@
-# Reference: https://editorconfig.org/#file-format-details
+# EditorConfig is awesome: https://EditorConfig.org
 
 root = true
 

.github/ISSUE_TEMPLATE/1-bug-report.yaml

@@ -36,8 +36,7 @@ body:
   - type: textarea
     id: exception-or-error
     attributes:
-      label: Please provide the exception or error you saw
-      render: console
+      label: Please provide the exception or error you saw (Preferably with a screenshot)
 
   - type: textarea
     id: device

.github/pull_request_template.md

@@ -5,33 +5,13 @@ Please include a summary of the change and which issue is fixed. Please also inc
 Fixes #(issue)
 
 ## PR Checklist
+
 Please check if your PR fulfills the following requirements:
 
 - [ ] Open an issue for bug report or feature request and mention it to this PR.
-- [ ] The commit message follows our guidelines: https://github.com/AliMD/vatr/blob/main/CONTRIBUTING.md#commit-message-format
+- [ ] The commit message follows our guidelines: <https://github.com/AliMD/vatr/blob/main/CONTRIBUTING.md#commit-message-format>
 - [ ] All methods have proper description in `jsdocs` format with `@example` section.
 - [ ] Docs have been added / updated (for bug fixes / features).
 - [ ] I have performed a self-review of my own code.
 
-
-## PR Type
-What kind of change does this PR introduce?
-
-<!-- Please check the one that applies to this PR using "x". -->
-
-- [ ] Bugfix
-- [ ] Feature
-- [ ] Code style update (formatting, local variables)
-- [ ] Refactoring (no functional changes, no api changes)
-- [ ] Build related changes
-- [ ] Documentation content changes
-- [ ] Other... Please describe:
-
-## Does this PR introduce a breaking change?
-
-- [ ] Yes
-- [ ] No
-
-<!-- If this PR contains a breaking change, please describe the impact and migration path for existing applications below. -->
-
 ## Other information

package.json

@@ -10,21 +10,22 @@
     "demo"
   ],
   "scripts": {
+    "l": "yarn lint",
     "b": "yarn build",
+    "cb": "npm-run-all --sequential clean build",
+    "s": "yarn serve:dev",
     "w": "yarn watch",
-    "s": "yarn serve",
-    "c": "yarn clean",
     "pm": "npm-run-all --sequential clean build ver-minor publish",
     "pp": "npm-run-all --sequential clean build ver-patch publish",
-    "build": "npm-run-all lint build:*",
-    "build:ts": "tsc --build",
-    "lint": "npm-run-all lint:*",
+    "lint": "npm-run-all --sequential lint:*",
     "lint:ts": "eslint **/*.ts",
-    "serve": "web-dev-server --config dev-server.mjs",
-    "prepare": "yarn build",
-    "watch": "npm-run-all --parallel watch:* serve",
-    "watch:ts": "yarn build:ts --watch",
+    "build": "npm-run-all --sequential lint:* build:*",
+    "build:ts": "tsc --build",
     "clean": "yarn build:ts --clean && lerna exec \"rm -rf dist node_modules\" && find package -name '*.js' -type f -delete && find package -name '*.d.ts' -type f -delete && find package -name '*.map' -type f -delete",
+    "serve:dev": "web-dev-server --config dev-server.mjs",
+    "watch": "npm-run-all --parallel watch:* serve:dev",
+    "watch:ts": "yarn build:ts --watch",
+    "prepare": "yarn build",
     "ver-minor": "lerna version minor --no-push && git push && git push --tags",
     "ver-patch": "lerna version patch --no-push && git push && git push --tags",
     "publish": "lerna publish from-package"

tsconfig.json

@@ -30,7 +30,7 @@
 
     /* Strict Type-Checking Options */
     "strict": true,                                 /* Enable all strict type-checking options. */
-    "noImplicitAny": false,                         /* Raise error on expressions and declarations with an implied 'any' type. */
+    // "noImplicitAny": false,                      /* Raise error on expressions and declarations with an implied 'any' type. */
     // "strictNullChecks": true,                    /* Enable strict null checks. */
     // "strictFunctionTypes": true,                 /* Enable strict checking of function types. */
     // "strictBindCallApply": true,                 /* Enable strict 'bind', 'call', and 'apply' methods on functions. */
@@ -43,6 +43,7 @@
     "noUnusedParameters": true,                     /* Report errors on unused parameters. */
     "noImplicitReturns": true,                      /* Report error when not all code paths in function return a value. */
     "noFallthroughCasesInSwitch": true,             /* Report errors for fallthrough cases in switch statement. */
+    "noImplicitOverride": true,                     /* Force to use override keyword when override super class methods. */
     // "noUncheckedIndexedAccess": true,            /* Include 'undefined' in index signature results */
     // "noPropertyAccessFromIndexSignature": true,  /* Require undeclared properties from index signatures to use element accesses. */