feat(com-pwa): review, refactor, release v1 #1050
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
alimd
commented
Apr 16, 2023
alimd
commented
Apr 16, 2023
alimd
commented
Apr 16, 2023
alimd
commented
Apr 16, 2023
alimd
commented
Apr 16, 2023
| `, | ||
| ]; | ||
| return html` | ||
| ${this.render_part_item_list(order.itemList ?? [], this.fsm.getContext().productStorage, false)} |
There was a problem hiding this comment.
کلا render_part_item_list رو برداریم به نظرم
There was a problem hiding this comment.
منم فکر میکنم shipping_form کافی هست
alimd
commented
Apr 16, 2023
alimd
commented
Apr 16, 2023
| </div> | ||
| `, | ||
| ]; | ||
| return html` |
alimd
commented
Apr 16, 2023
alimd
force-pushed
the
feat/com
branch
3 times, most recently
from
d5284ec to
b555b9f
Compare
…nd then go to show its details
Co-authored-by: Mohammad Honarvar <honarvar.info@gmail.com>
Co-authored-by: Mohammad Honarvar <honarvar.info@gmail.com>
Co-authored-by: Mohammad Honarvar <honarvar.info@gmail.com>
| }); | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-non-null-assertion | ||
| const order = this.fsm.getContext().orderStorage!.data[this.fsm.getContext().orderId]; |
Check warning
Code scanning / ESLint
Disallow non-null assertions using the `!` postfix operator
njfamirm
reviewed
Apr 20, 2023
| @@ -1,6 +1,6 @@ | |||
| window.appConfig = { | |||
| api: 'https://order.soffit.co/api/v0', | |||
| cdn: '/cdn/', | |||
| cdn: 'https://order.soffit.co/cdn/', | |||
There was a problem hiding this comment.
این اشتباه نیست؟
توی دولوپ لوکال بهتره
ولی بخوایم با دامنه دیگه بیاریم بالا کار نمیکنه
مثل demo.order.soffit.co
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.