Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(i18n): issue #154 #155

Closed
wants to merge 4 commits into from
Closed

fix(i18n): issue #154 #155

wants to merge 4 commits into from

Conversation

MM25Zamanian
Copy link
Contributor

@MM25Zamanian MM25Zamanian commented May 16, 2022

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes #154

PR Checklist

Please check if your PR fulfills the following requirements:

@MM25Zamanian MM25Zamanian added this to the v1.0.0 milestone May 16, 2022
@MM25Zamanian MM25Zamanian requested review from alimd and asmanp2012 May 16, 2022 17:22
@MM25Zamanian MM25Zamanian self-assigned this May 16, 2022
@MM25Zamanian MM25Zamanian linked an issue May 16, 2022 that may be closed by this pull request
Copy link
Member

@alimd alimd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

اینکه کلا چک نکنه که نمیشه! باعث میشه تکراری لود بشه
بهترین راه برای اینکه بفهمیم لوکال واقعا فرق کرده چیه؟
تازه ممکنه ریسورس درست لود نشده باشه پس باید با خود ریسورس چک بشه! یا به قول شما اصلا چک نشه راحت تره
باید حرف بزنیم

@alimd
Copy link
Member

alimd commented May 17, 2022

اینکه fetch امکان catch داشته باشه فکر کنم از همه بهتر باشه
یا حتی اینکه خود این تابع امکان کش داشته باشه، مشکل کامل حل میشه

@MM25Zamanian
Copy link
Contributor Author

خب من چه کنم الان ؟؟؟

@MM25Zamanian MM25Zamanian requested a review from alimd May 23, 2022 20:28
@alimd
Copy link
Member

alimd commented Jul 20, 2022

Fixed in #165

@alimd alimd closed this in #165 Jul 20, 2022
@github-actions
Copy link

Pull Request closed and locked due to lack of activity.
If you'd like to build on this closed PR, you can clone it using this method: https://stackoverflow.com/a/14969986
Then open a new PR, referencing this closed PR in your message.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2022
@alimd alimd deleted the bugfix/i18n branch October 21, 2022 07:55
@alimd alimd modified the milestones: v1.0.0, v0.x Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

i18n: Package not Working
3 participants