Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor signal #217

Merged
merged 2 commits into from
Aug 21, 2022
Merged

Refactor signal #217

merged 2 commits into from
Aug 21, 2022

Conversation

mohammadhonarvar
Copy link
Member

@mohammadhonarvar mohammadhonarvar commented Aug 21, 2022 •
edited by MM25Zamanian
Loading

…use signal object instead of signalName

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes #(issue)

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

@mohammadhonarvar
refactor(signal): add a global signalCounter instead of Symbol & …
73c1c23 
…use `signal` object instead of `signalName`
@mohammadhonarvar mohammadhonarvar added enhancement Enhancement of the code, not introducing new features. feature request labels Aug 21, 2022
@mohammadhonarvar mohammadhonarvar added this to the v1.0.0-beta milestone Aug 21, 2022
@mohammadhonarvar mohammadhonarvar requested a review from alimd August 21, 2022 16:51
@mohammadhonarvar mohammadhonarvar self-assigned this Aug 21, 2022
alimd
alimd requested changes Aug 21, 2022
View reviewed changes
Copy link
Member

@alimd alimd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

مرسی
عالی شده
همین نکات کوچیک رو لطفا اصلاح کن

packages/core/signal/src/core.ts Outdated Show resolved Hide resolved
packages/core/signal/src/core.ts Outdated Show resolved Hide resolved
packages/core/signal/src/core.ts Outdated Show resolved Hide resolved
packages/core/signal/src/core.ts Show resolved Hide resolved
packages/core/signal/src/signal.ts Outdated Show resolved Hide resolved
packages/core/signal/src/type.ts Outdated Show resolved Hide resolved
packages/core/signal/src/signal.ts Outdated Show resolved Hide resolved
alimd
alimd approved these changes Aug 21, 2022
View reviewed changes
Copy link
Member

@alimd alimd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@alimd alimd merged commit b18700d into next Aug 21, 2022
@alimd alimd deleted the feature/refactor-signal branch August 21, 2022 17:49
@alimd alimd changed the title refactor(signal): add a global signalCounter instead of Symbol & … Refactor signal Aug 21, 2022
@github-actions
Copy link

Pull Request closed and locked due to lack of activity.
If you'd like to build on this closed PR, you can clone it using this method: https://stackoverflow.com/a/14969986
Then open a new PR, referencing this closed PR in your message.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alimd alimd alimd approved these changes

Assignees

@mohammadhonarvar mohammadhonarvar

Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Milestone
v0.x
Development

Successfully merging this pull request may close these issues.
2 participants
@mohammadhonarvar @alimd