Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documention #254

Merged
merged 15 commits into from
Sep 24, 2022
Merged

Improve documention #254

merged 15 commits into from
Sep 24, 2022

Conversation

njfamirm
Copy link
Member

@njfamirm njfamirm commented Aug 31, 2022

  • Rename Angular in feature request description
  • Add new packages to issue_template

@njfamirm njfamirm added the documentation Solely about the documentation of the project. label Aug 31, 2022
@njfamirm njfamirm requested a review from alimd August 31, 2022 18:15
@njfamirm njfamirm self-assigned this Aug 31, 2022
@njfamirm
Copy link
Member Author

#152

@alimd لطفا تغییراتی که لازمه رو بگین از این بردارم

@alimd
Copy link
Member

alimd commented Sep 18, 2022

?!
این چیه داستانش
تمامش کنیم

@njfamirm
Copy link
Member Author

یکسری خورده کاریا
و همچنین اونایی که از #153 خوب بود رو اینجا منتقل میکنم

@njfamirm
Copy link
Member Author

#152

@alimd لطفا تغییراتی که لازمه رو بگین از این بردارم

بگین همین رو

@alimd
Copy link
Member

alimd commented Sep 19, 2022

یکی تنظیمات eslint

قانون operator-linebreak باید این باشه

"after", { "overrides": { "?": "before", ":": "before" } }
این مقدار پیشفرض هستش آیا واقعا لازمه نوشته بشه؟

و maxlen که اینم فکر کنم همین الان هم ۱۲۰ باشه

@alimd
Copy link
Member

alimd commented Sep 19, 2022

یکی تنظیمات prettier که جدا بررسیش کنیم
خیلی از چیزهایی که میخوایم در این لامصب اصلا تنظیم نداره
شاید اگر بیاد تو eslint بشه با تنظیمات eslint خودمون override کنیم و دیگه دو بار اعمال نشه
و اگر خیلی مهم نیست مدل prettier رو بپذیریم 💩

Co-authored-by: Younes Adltalab <adltalab@gmail.com>
@alimd
Copy link
Member

alimd commented Sep 19, 2022

یک موضوع مهم دو فایل برای prettierignore و eslintignore میخوایم و باید حالت فعلی که از gitignpre استفاده میکنه تغییر کنه

@njfamirm njfamirm marked this pull request as ready for review September 23, 2022 08:52
@@ -5,7 +5,7 @@ import exitHook from 'exit-hook';

import {readJsonFile, writeJsonFile} from './util.js';

import type {DocumentObject, DocumentListStorage, AlwatrStorageConfig} from './type';
import type {DocumentObject, DocumentListStorage, AlwatrStorageConfig} from './type.js';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

تو import type که .js لازم نداره!

@@ -133,6 +133,7 @@ export class SignalInterface<SignalName extends keyof AlwatrSignals> {
): ListenerInterface<SignalName> {
this._logger.logMethodArgs('setProvider', {options});
const listener = _setSignalProvider(this._signal, this._requestSignal, signalProvider, options);
// eslint-disable-next-line @typescript-eslint/no-use-before-define
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

این چیه؟

@@ -37,6 +37,7 @@
"space-infix-ops": "error",
"new-cap": ["error", {"capIsNewExceptionPattern": "Mixin$"}],
"brace-style": ["error", "stroustrup", {"allowSingleLine": true}],
"operator-linebreak": ["error", "after", {"overrides": {"?": "before", ":": "before"}}],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

این مگه default نبود؟

@alimd alimd merged commit 6af549a into next Sep 24, 2022
@alimd alimd deleted the feat/doc branch September 24, 2022 10:57
@github-actions
Copy link

Pull Request closed and locked due to lack of activity.
If you'd like to build on this closed PR, you can clone it using this method: https://stackoverflow.com/a/14969986
Then open a new PR, referencing this closed PR in your message.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 27, 2022
@njfamirm njfamirm added this to the v0.x milestone Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
documentation Solely about the documentation of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants