-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve documention #254
Improve documention #254
Conversation
?! |
یکسری خورده کاریا |
یکی تنظیمات eslint قانون operator-linebreak باید این باشه
و maxlen که اینم فکر کنم همین الان هم ۱۲۰ باشه |
یکی تنظیمات prettier که جدا بررسیش کنیم |
Co-authored-by: Younes Adltalab <adltalab@gmail.com>
یک موضوع مهم دو فایل برای prettierignore و eslintignore میخوایم و باید حالت فعلی که از gitignpre استفاده میکنه تغییر کنه |
@@ -5,7 +5,7 @@ import exitHook from 'exit-hook'; | |||
|
|||
import {readJsonFile, writeJsonFile} from './util.js'; | |||
|
|||
import type {DocumentObject, DocumentListStorage, AlwatrStorageConfig} from './type'; | |||
import type {DocumentObject, DocumentListStorage, AlwatrStorageConfig} from './type.js'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
تو import type که .js لازم نداره!
packages/core/signal/src/signal.ts
Outdated
@@ -133,6 +133,7 @@ export class SignalInterface<SignalName extends keyof AlwatrSignals> { | |||
): ListenerInterface<SignalName> { | |||
this._logger.logMethodArgs('setProvider', {options}); | |||
const listener = _setSignalProvider(this._signal, this._requestSignal, signalProvider, options); | |||
// eslint-disable-next-line @typescript-eslint/no-use-before-define |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
این چیه؟
@@ -37,6 +37,7 @@ | |||
"space-infix-ops": "error", | |||
"new-cap": ["error", {"capIsNewExceptionPattern": "Mixin$"}], | |||
"brace-style": ["error", "stroustrup", {"allowSingleLine": true}], | |||
"operator-linebreak": ["error", "after", {"overrides": {"?": "before", ":": "before"}}], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
این مگه default نبود؟
Pull Request closed and locked due to lack of activity. |
Angular
in feature request description