Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(logger): accident must inherit from console.warn not console.error #272

Merged
merged 2 commits into from
Sep 18, 2022
Merged

fix(logger): accident must inherit from console.warn not console.error #272

merged 2 commits into from
Sep 18, 2022

Conversation

MM25Zamanian
Copy link
Contributor

PR Checklist

@MM25Zamanian MM25Zamanian added bug enhancement Enhancement of the code, not introducing new features. labels Sep 9, 2022
@MM25Zamanian MM25Zamanian self-assigned this Sep 9, 2022
alimd
alimd approved these changes Sep 18, 2022
View reviewed changes
Copy link
Member

@alimd alimd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏻

@alimd alimd merged commit f3829e3 into next Sep 18, 2022
@alimd alimd deleted the bugfix/logger branch September 18, 2022 21:54
@github-actions
Copy link

Pull Request closed and locked due to lack of activity.
If you'd like to build on this closed PR, you can clone it using this method: https://stackoverflow.com/a/14969986
Then open a new PR, referencing this closed PR in your message.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 20, 2022
@alimd alimd changed the title accident must inherit from console.warn not console.error fix(logger): accident must inherit from console.warn not console.error Oct 21, 2022
@njfamirm njfamirm added this to the v0.x milestone Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@alimd alimd alimd approved these changes

@njfamirm njfamirm Awaiting requested review from njfamirm

Assignees

@MM25Zamanian MM25Zamanian

Labels
enhancement Enhancement of the code, not introducing new features.
Projects
None yet
Milestone
v0.x
Development

Successfully merging this pull request may close these issues.
3 participants
@MM25Zamanian @alimd @njfamirm