Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Package: @alwatr/icon #362

Merged
merged 7 commits into from
Nov 5, 2022
Merged

New Package: @alwatr/icon #362

merged 7 commits into from
Nov 5, 2022

Conversation

MM25Zamanian
Copy link
Contributor

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context.

Fixes #(issue)

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

@MM25Zamanian MM25Zamanian requested a review from alimd as a code owner November 2, 2022 19:49
@MM25Zamanian MM25Zamanian self-assigned this Nov 2, 2022
@MM25Zamanian MM25Zamanian added the enhancement Enhancement of the code, not introducing new features. label Nov 2, 2022
@MM25Zamanian MM25Zamanian changed the title feat(alwatr-icon): icon component build alwatr-icon component Nov 2, 2022
@alimd alimd changed the title build alwatr-icon component New Package: @alwatr/icon Nov 3, 2022
@alimd
Copy link
Member

alimd commented Nov 5, 2022

@MM25Zamanian
دارم ریویو و پوش میکنم
کاری موازی نکنی!

'woman',
];

const container = document.querySelector('.icons')!;

Check warning

Code scanning / ESLint

Disallow non-null assertions using the `!` postfix operator

Forbidden non-null assertion.
@alimd
Copy link
Member

alimd commented Nov 5, 2022

#109

@alimd
Copy link
Member

alimd commented Nov 5, 2022

Fixed #211

@alimd alimd added this to the v1.0.0-beta milestone Nov 5, 2022
@alimd alimd added the new-feature New features or options. label Nov 5, 2022
@alimd alimd linked an issue Nov 5, 2022 that may be closed by this pull request
@alimd alimd merged commit a9925ee into next Nov 5, 2022
@alimd alimd deleted the feat/icon branch November 5, 2022 12:21
@github-actions
Copy link

github-actions bot commented Nov 7, 2022

Pull Request closed and locked due to lack of activity.
If you'd like to build on this closed PR, you can clone it using this method: https://stackoverflow.com/a/14969986
Then open a new PR, referencing this closed PR in your message.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Enhancement of the code, not introducing new features. new-feature New features or options.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

alwatr-icon element
2 participants