fix(logger/define-package): throw error if duplicate_package_defined (#…

…96)
Alwatr · Dec 11, 2023 · c0bbbf9 · c0bbbf9
2 parents 932c439 + c32be46
commit c0bbbf9
Showing 1 changed file with 9 additions and 2 deletions.
diff --git a/packages/logger/src/define-package.ts b/packages/logger/src/define-package.ts
@@ -15,12 +15,19 @@ export const definePackage = (packageName: string, version: string) => {
   logger.logMethodArgs?.('define-package', {packageName, version});
 
   if (packageName in Alwatr.packages) {
-    logger.accident?.('define-package', 'duplicate_package_defined', {
+    logger.error('define-package', 'duplicate_package_defined', {
       packageName,
       new: version,
       old: Alwatr.packages[packageName],
     });
-    return;
+    throw new Error('duplicate_package_defined');
+  }
+
+  if (packageName.indexOf('@alwatr') === -1) {
+    logger.error('define-package', 'package_name_starts_with_alwatr_scope', {
+      packageName,
+    });
+    throw new Error('package_name_starts_with_alwatr_scope');
   }
 
   Alwatr.packages[packageName] = version;