Fix link decoration for enhanced rendering #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your changes! I have merged them and released version v1.0.9 which includes your changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the enhanced rendering and caption numbering, the caption link doesn't have a space to the title (when a caption is present). I believe the numbered caption is stored with a space at the end of the string for the "normal" numbering throughout the document. This confuses the link decoration and just assumes all whitespace after it belongs to the link as well. This leads to wrong display in the lists:
Current behavior:
Space stripped from caption:
I've also removed the unnecessary stuff from the else conditions for these cases.