feat: fallback locales #1097
Merged
feat: fallback locales #1097
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpaul-1A
reviewed
Nov 14, 2023
vscaiceanu-1a
previously approved these changes
Nov 14, 2023
src/templates/prefetch.mustache
Outdated
| if (prefetchConfig.fallbackLocalesMap && prefetchConfig.fallbackLocalesMap[language]) { | ||
| language = prefetchConfig.fallbackLocalesMap[language]; | ||
| } | ||
| var locPattern = `{{{localizationPattern}}}`; | ||
| resList.push(locPattern); |
There was a problem hiding this comment.
Suggested change
| resList.push(locPattern); | |
| resList.push(`{{{localizationPattern}}}`); |
fpaul-1A
reviewed
Nov 16, 2023
sdo-1A
force-pushed
the
feat/fallback-locales
branch
2 times, most recently
from
5f54a3f
to
a538246
Compare
fpaul-1A
reviewed
Nov 16, 2023
sdo-1A
force-pushed
the
feat/fallback-locales
branch
from
a538246
to
e290cde
Compare
fpaul-1A
previously approved these changes
Nov 16, 2023
sdo-1A
force-pushed
the
feat/fallback-locales
branch
from
e290cde
to
dcb5407
Compare
sdo-1A
force-pushed
the
feat/fallback-locales
branch
from
dcb5407
to
76e1dcc
Compare
vscaiceanu-1a
previously approved these changes
Nov 17, 2023
fpaul-1A
previously approved these changes
Nov 17, 2023
sdo-1A
force-pushed
the
feat/fallback-locales
branch
from
76e1dcc
to
6fde9a9
Compare
vscaiceanu-1a
approved these changes
Nov 20, 2023
fpaul-1A
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.