Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Improve @ama-sdk plugins logging #1009

Closed
cpaulve-1A opened this issue Nov 6, 2023 · 1 comment
Closed

[Feature]: Improve @ama-sdk plugins logging #1009

cpaulve-1A opened this issue Nov 6, 2023 · 1 comment
Assignees
@sdo-1A
Labels
enhancement New feature or request
Milestone
Otter Version 10

Comments

@cpaulve-1A
Copy link
Contributor

Context

There is no dedicated logging in the @ama-sdk/core. The errors are logged in the console and it is up to the application to catch them and handle them (via the Angular Error Handler for example).

Proposal

Create a dedicated logger for the API plugins and calls.
@cpaulve-1A cpaulve-1A added the enhancement New feature or request label Nov 6, 2023
@kpanot
Copy link
Contributor

kpanot commented Nov 7, 2023 •
edited
Loading

This feature is next step of the quick fix from #1008

@kpanot kpanot added this to the SDK Enhancement milestone Dec 2, 2023
@sdo-1A sdo-1A mentioned this issue Jan 4, 2024
Merged
sdo-1A added a commit that referenced this issue Jan 12, 2024
@sdo-1A
feat: improve ama-sdk plugins logging (#1184)
0cab03b 
## Proposed change

Possibility to connect a third-party logger in ama-sdk, fallback to
console logger if undefined.

## Related issues

- 🚀 Feature #1009
@sdo-1A sdo-1A closed this as completed Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sdo-1A sdo-1A

Labels
enhancement New feature or request
Projects
None yet
Milestone
Otter Version 10
Development

No branches or pull requests
3 participants
@kpanot @cpaulve-1A @sdo-1A