Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Reference to Digital and DES should be removed #1190

Open
vscaiceanu-1a opened this issue Jan 5, 2024 · 8 comments
Open

[Bug]: Reference to Digital and DES should be removed #1190

vscaiceanu-1a opened this issue Jan 5, 2024 · 8 comments
Assignees
Labels
documentation Improvements or additions to documentation priority:low

Comments

@vscaiceanu-1a
Copy link
Member

vscaiceanu-1a commented Jan 5, 2024

Package name

all packages

Package version

9.5.0

Reproduction steps

Search for DES and Digital in the repository

Current result

image

Many references are still present

Expected result

References to Digital and DES should be removed

Additional comments

No response

@vscaiceanu-1a vscaiceanu-1a added the bug Something isn't working label Jan 5, 2024
@kpanot kpanot added the documentation Improvements or additions to documentation label Jan 5, 2024
@khardikk
Copy link

khardikk commented Jan 8, 2024

Hi @vscaiceanu-1a can i work on this issue? I have gone through the code, wanted to know if we remove the references to DES and Digital then will it not effect further paragraphs dependent on it. Like this one for instance.
image

@kpanot
Copy link
Contributor

kpanot commented Jan 9, 2024

Hi @khardikk ,

Sure you can you can work on the task.
please do assign it to ourself before starting.

To reply to your question: it is depending of the link:

  • if the link is targetinbg DES/Digital documentation/application that is not already part of this repository (or https://github.com/AmadeusITGroup/ngx-prefetch/), it can be removed. (Up to the reviewer of the Pull Request do decide if the targeted document can be opened later on).
  • if the link is targeted old documentation as is now already part of this repository (the one targeted in your screenshot for example), this link need to be re-targeted (and link label can be also potentially be changed).

@kpanot kpanot added this to the On boarding improvement milestone Jan 9, 2024
@khardikk
Copy link

Hi @khardikk ,

Sure you can you can work on the task.
please do assign it to ourself before starting.

To reply to your question: it is depending of the link:

  • if the link is targetinbg DES/Digital documentation/application that is not already part of this repository (or https://github.com/AmadeusITGroup/ngx-prefetch/), it can be removed. (Up to the reviewer of the Pull Request do decide if the targeted document can be opened later on).
  • if the link is targeted old documentation as is now already part of this repository (the one targeted in your screenshot for example), this link need to be re-targeted (and link label can be also potentially be changed).

Hey @kpanot thanks for letting me work on this, wanted to ask, how can I assign it to myself as I don't have the permissions.

@kpanot
Copy link
Contributor

kpanot commented Jan 10, 2024

@khardikk ,
My bad, I did not realize you need the permission for it.
I have now assigned the issue to you.

@khardikk
Copy link

Hi @khardikk ,

Sure you can you can work on the task. please do assign it to ourself before starting.

To reply to your question: it is depending of the link:

  • if the link is targetinbg DES/Digital documentation/application that is not already part of this repository (or https://github.com/AmadeusITGroup/ngx-prefetch/), it can be removed. (Up to the reviewer of the Pull Request do decide if the targeted document can be opened later on).
  • if the link is targeted old documentation as is now already part of this repository (the one targeted in your screenshot for example), this link need to be re-targeted (and link label can be also potentially be changed).

Hi @kpanot as you mentioned, the links that are already part of this repo, need to be re-targeted, where do they need to be re-targeted exactly?

@kpanot
Copy link
Contributor

kpanot commented Jan 16, 2024

Hi @khardikk ,
If a link is targeting a document that does not exist (or part of an non-accessible repository) but a documentation matching matching the link is present in this repository, then the URL of the link need to be changed to target this matching documentation.

@vscaiceanu-1a
Copy link
Member Author

hi @khardikk
Don't worry that much about the links, it Will be fixed in #1267

@khardikk
Copy link

hi @khardikk
Don't worry that much about the links, it Will be fixed in #1267

Alright thanks for letting me know

github-merge-queue bot pushed a commit that referenced this issue Jan 25, 2024
## Proposed change
Similarly to #1190, the
goal is to cleanup references to RefX.

There are still references in the:
- [ ] theming part
- [ ] amaterasu

To be discussed if those references are to be kept or not.
@pginoux-1A pginoux-1A added priority:low and removed bug Something isn't working labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation priority:low
Projects
None yet
Development

No branches or pull requests

4 participants