Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: ng add localization not working on libraries #1758

Closed
vscaiceanu-1a opened this issue May 7, 2024 · 0 comments · Fixed by #1995
Closed

[Bug]: ng add localization not working on libraries #1758

vscaiceanu-1a opened this issue May 7, 2024 · 0 comments · Fixed by #1995
Labels
bug Something isn't working priority:high

Comments

@vscaiceanu-1a
Copy link
Member

Package name

localization

Package version

10.2.1

Reproduction steps

npm create @o3r my-workspace
cd my workspace
ng g library my-lib
ng add @o3r/localization --project-name my-lib

Current result

Would you like to proceed? Yes
✔ Packages successfully installed.
    The package @o3r/localization comes with a debug mechanism
    Get information on https://github.com/AmadeusITGroup/otter/tree/main/docs/localization/LOCALIZATION.md#Debugging
Cannot read properties of null (reading 'toString')

Expected result

package is added correctly

Additional comments

No response
@vscaiceanu-1a vscaiceanu-1a added bug Something isn't working triage labels May 7, 2024
@vscaiceanu-1a vscaiceanu-1a mentioned this issue May 7, 2024
Merged
16 tasks
github-merge-queue bot pushed a commit that referenced this issue Jun 12, 2024
@vscaiceanu-1a
test: library integration tests (#1725)
c9aa734 
## Proposed change

Enhance the integration test campaign with tests for libraries.

- [x] `@o3r/create` should generate a project with a library
- [x] base Otter project should contain a library as well (along with an
application)
- [x] check generated files by `@o3r/workspace` schematic for app and
lib. Currently in create int tests, to be moved in workspace ones.
#1678 should be merged
first.

Ensure test coverage for libs (similar to what we have for apps) and add
assertions for app tests for:
- [x] eslint-config-otter
- [x] stylelint-plugin
- [x] configuration
- [x] apis-manager
- [x] localization. reactive test for lib after
#1758
- [x] rules-engine
- [x] components
- [x] extractors
- [x] analytics
- [x] styling
- [x] testing
- [x] design
- [x] core
@matthieu-crouzet matthieu-crouzet mentioned this issue Jul 24, 2024
Merged
github-merge-queue bot pushed a commit that referenced this issue Jul 29, 2024
@matthieu-crouzet
fix(ng-add localization): create the assets array if not present (#1995)
1ac0a6c 
## Proposed change
Create the assets array if not present

## Related issues

- 🐛 Fixes #1758
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working priority:high
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(ng-add localization): create the assets array if not present AmadeusITGroup/otter
2 participants
@vscaiceanu-1a @sdo-1A