Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: ng add @o3r/design does not work #1771

Closed
vscaiceanu-1a opened this issue May 10, 2024 · 1 comment · Fixed by #1992
Closed

[Bug]: ng add @o3r/design does not work #1771

vscaiceanu-1a opened this issue May 10, 2024 · 1 comment · Fixed by #1992
Assignees
@vscaiceanu-1a
Labels
bug Something isn't working priority:medium

Comments

@vscaiceanu-1a
Copy link
Member

vscaiceanu-1a commented May 10, 2024 •
edited

Package name

design

Package version

10.2.1

Reproduction steps

npm create @o3r my-workspace
cd my-workspace
ng g app webapp
ng add @o3r/design --project-name webapp

Current result

In angular.json

  • "useOtterDesignToken": true, is added for all projects. Shouldn't it be only for webapp?
  • generate-css builder is not added
    Also, no template files are added to the project (design-token.custom.json and theme.scss)

Expected result

In angular.json

  • "useOtterDesignToken": true, is added only for webapp?
  • generate-css builder is added for webapp
    Template files are added to the project (design-token.custom.json and theme.scss)

Additional comments

No response
@vscaiceanu-1a vscaiceanu-1a added bug Something isn't working triage labels May 10, 2024
@vscaiceanu-1a vscaiceanu-1a self-assigned this May 13, 2024
@kpanot kpanot mentioned this issue Jul 24, 2024
Merged
@vscaiceanu-1a
Copy link
Member Author

Integration tests should be enhanced to verify everything works well for the ng add

github-merge-queue bot pushed a commit that referenced this issue Jul 31, 2024
@kpanot
fix(design): ng add angular.json updates and file creation (#1992)
1774cb9 
## Proposed change

Fix ngAdd schemtics to correctly add @o3r/design package

<!-- Please include a summary of the changes and the related issue.
Please also include relevant motivation and context. List any
dependencies that is required for this change. -->

## Related issues

- 🐛 Fixes #1771

<!-- Please make sure to follow the contributing guidelines on
https://github.com/amadeus-digital/Otter/blob/main/CONTRIBUTING.md -->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vscaiceanu-1a vscaiceanu-1a

Labels
bug Something isn't working priority:medium
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(design): ng add angular.json updates and file creation AmadeusITGroup/otter
2 participants
@vscaiceanu-1a @sdo-1A