Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature]: Use takeUntilDestroy instead of subscription array #1874

Open
matthieu-crouzet opened this issue Jun 10, 2024 · 0 comments
Open

[Feature]: Use takeUntilDestroy instead of subscription array #1874

matthieu-crouzet opened this issue Jun 10, 2024 · 0 comments
Labels
devExp Development Experience enhancement New feature or request priority:low

Comments

@matthieu-crouzet
Copy link
Contributor

Context

Since angular v17 we can use takeUntilDestroy from @angular/core/rxjs-interop

Proposal

We should replace all subscription array with the unsubscription in the ngOnDestroy by takeUntilDestroy.
We should modify our schematic that generate subscription array
@matthieu-crouzet matthieu-crouzet added enhancement New feature or request devExp Development Experience priority:low labels Jun 10, 2024
@matthieu-crouzet matthieu-crouzet mentioned this issue Jun 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
devExp Development Experience enhancement New feature or request priority:low
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@matthieu-crouzet